Merge lp:~vthompson/music-app/remix-do-not-show-artist-in-albumspage into lp:music-app/remix

Proposed by Victor Thompson
Status: Merged
Approved by: Andrew Hayzen
Approved revision: 682
Merged at revision: 687
Proposed branch: lp:~vthompson/music-app/remix-do-not-show-artist-in-albumspage
Merge into: lp:music-app/remix
Diff against target: 12 lines (+1/-1)
1 file modified
common/AlbumsPage.qml (+1/-1)
To merge this branch: bzr merge lp:~vthompson/music-app/remix-do-not-show-artist-in-albumspage
Reviewer Review Type Date Requested Status
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Andrew Hayzen Approve
Review via email: mp+239084@code.launchpad.net

This proposal supersedes a proposal from 2014-10-21.

Commit message

Do not show the artist in the grid of albums

Description of the change

Do not show the artist in the grid of albums

To post a comment you must log in.
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Andrew Hayzen (ahayzen) wrote :

LGTM :)

review: Approve
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'common/AlbumsPage.qml'
2--- common/AlbumsPage.qml 2014-10-20 21:36:20 +0000
3+++ common/AlbumsPage.qml 2014-10-21 15:34:10 +0000
4@@ -142,7 +142,7 @@
5 coverSources: [{art: model.art}]
6 objectName: "albumsPageGridItem" + index
7 primaryText: model.title
8- secondaryText: model.artist
9+ secondaryTextVisible: false
10
11 onClicked: {
12 songsPage.album = model.title;

Subscribers

People subscribed via source and target branches