Merge lp:~vthompson/music-app/remix-add-clear-queue into lp:music-app/remix
Proposed by
Victor Thompson
Status: | Merged |
---|---|
Approved by: | Andrew Hayzen |
Approved revision: | 666 |
Merged at revision: | 666 |
Proposed branch: | lp:~vthompson/music-app/remix-add-clear-queue |
Merge into: | lp:music-app/remix |
Diff against target: |
22 lines (+10/-1) 1 file modified
MusicNowPlaying.qml (+10/-1) |
To merge this branch: | bzr merge lp:~vthompson/music-app/remix-add-clear-queue |
Related bugs: | |
Related blueprints: |
Music Remix for RTM
(Essential)
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Andrew Hayzen | Approve | ||
Ubuntu Phone Apps Jenkins Bot | continuous-integration | Approve | |
Review via email:
|
This proposal supersedes a proposal from 2014-10-13.
Commit message
Add clear queue action
Description of the change
A discussion with design came up with a way of fixing the currently confusing pattern of navigating back to other views in the app from the Queue. The conclusion was to have the list icon toggle the view to and from the Queue, and keep the chevron as a "back to library" action. Also, a clear queue action is to be added to the Queue view--as that is what the x icon was supposed to do.
To post a comment you must log in.
PASSED: Continuous integration, rev:666 91.189. 93.70:8080/ job/music- app-remix- ci/83/ 91.189. 93.70:8080/ job/generic- mediumtests- utopic- python3/ 908 91.189. 93.70:8080/ job/generic- mediumtests- utopic- python3/ 908/artifact/ work/output/ *zip*/output. zip 91.189. 93.70:8080/ job/music- app-remix- utopic- amd64-ci/ 83
http://
Executed test runs:
SUCCESS: http://
deb: http://
SUCCESS: http://
Click here to trigger a rebuild: 91.189. 93.70:8080/ job/music- app-remix- ci/83/rebuild
http://