lp:~vthompson/music-app/refactor-fix-1428913

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp:music-app at revision 843

Andrew Hayzen: Approve on 2015-03-07

Ubuntu Phone Apps Jenkins Bot: Approve (continuous-integration) on 2015-03-06

Diff: 35 lines (+10/-12)

1 file modified

app/components/ListItemReorderComponent.qml (+10/-12)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #1428913: Reordering the last item in a list (Playlist or Queue) can stick it in an improperly stuck location

Low

Fix Released

Link a bug report

Related blueprints

843. By Victor Thompson on 2015-03-06

Trigger list reset animation when the index did not change.

842. By Andrew Hayzen on 2015-03-06

* Destroy dialog before popping page. Fixes: https://bugs.launchpad.net/bugs/1428450.

Approved by Ubuntu Phone Apps Jenkins Bot, Victor Thompson.

841. By Andrew Hayzen on 2015-03-05

* Move delegates into their own folder in components
* Split out multiselect/reorder code from ListItemWithActions.qml into MusicListItem.qml and remove use of primed in ListItemWithActions.qml as it is not used anymore
* Fix for ListItemWithActions.qml if user swipes left and clicks where a rightAction would have been (has to be enabled) causes a console error and doesn't reset the swipe.

Approved by Victor Thompson, Ubuntu Phone Apps Jenkins Bot.

840. By Andrew Hayzen on 2015-02-08

* Create generic MultiSelectListView.qml for handling multiselect
* Create MusicListView.qml with our patches to ListView
* Move Flickables from components into their own Flickables folder.

Approved by Victor Thompson, Ubuntu Phone Apps Jenkins Bot.

839. By Andrew Hayzen on 2015-02-08

* Do not allow LibraryEmptyState loader to be active if content-hub is running. Fixes: https://bugs.launchpad.net/bugs/1418366.

Approved by Victor Thompson, Ubuntu Phone Apps Jenkins Bot.

838. By Andrew Hayzen on 2015-02-07

* Move all Dialog components into their own files in components/Dialog.

Approved by Victor Thompson, Ubuntu Phone Apps Jenkins Bot.

837. By Andrew Hayzen on 2015-02-07

* Create common components for Play All, Queue All and Shuffle buttons within 'Views'.

Approved by Victor Thompson, Ubuntu Phone Apps Jenkins Bot.

836. By Andrew Hayzen on 2015-02-05

* Split EmptyStates into a page (for noMusic) and a component (for noPlaylists) and load in async.

Approved by Ubuntu Phone Apps Jenkins Bot, Victor Thompson.

835. By Andrew Hayzen on 2015-02-05

* Move existing head states into HeadState folder
* Create MultiSelectHeadState SearchableHeadState PlaylistHeadState
* Migrate AddToPlaylist Albums Artists Genres NowPlaying Playlists Songs SongsView to use the new HeadState.

Approved by Ubuntu Phone Apps Jenkins Bot, Victor Thompson.

834. By Andrew Hayzen on 2015-02-05

* Make use of SDK PageStack.push(url, properties) instead of creating the component, object and pushing ourselves.

Approved by Victor Thompson, Ubuntu Phone Apps Jenkins Bot.