Ubuntu Music App

Merge lp:~vthompson/music-app/make-images-asynchronous into lp:music-app/remix

  1. make-images-asynchronous
  2. Merge into remix
Proposed by Victor Thompson
Status: Merged
Approved by: Andrew Hayzen
Approved revision: 680
Merged at revision: 682
Proposed branch: lp:~vthompson/music-app/make-images-asynchronous
Merge into: lp:music-app/remix
Diff against target: 23 lines (+2/-0)
2 files modified
common/BlurredBackground.qml (+1/-0)
common/CoverGrid.qml (+1/-0)
To merge this branch: bzr merge lp:~vthompson/music-app/make-images-asynchronous
Reviewer Review Type Date Requested Status
Andrew Hayzen Approve
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Review via email: mp+239005@code.launchpad.net

Commit message

Make Images asynchronous

Description of the change

Make Images asynchronous. Discussions with Bill Filler and Renato Filho lead to the idea that images provided by Thumbnailer might be best made asynchronous as to not block the UI. This seems to be the case from initial testing.

To post a comment you must log in.
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :

PASSED: Continuous integration, rev:680
http://91.189.93.70:8080/job/music-app-remix-ci/122/
Executed test runs:
    SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-utopic-python3/1088
        deb: http://91.189.93.70:8080/job/generic-mediumtests-utopic-python3/1088/artifact/work/output/*zip*/output.zip
    SUCCESS: http://91.189.93.70:8080/job/music-app-remix-utopic-amd64-ci/122

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/music-app-remix-ci/122/rebuild

review: Approve (continuous-integration)
Revision history for this message
Andrew Hayzen (ahayzen) wrote :

LGTM :)

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'common/BlurredBackground.qml'
2--- common/BlurredBackground.qml 2014-10-20 15:56:44 +0000
3+++ common/BlurredBackground.qml 2014-10-21 03:20:36 +0000
4@@ -37,6 +37,7 @@
5 id: backgroundImage
6 anchors.horizontalCenter: parent.horizontalCenter
7 anchors.verticalCenter: parent.verticalCenter
8+ asynchronous: true
9 source: art // this has to be fixed for the default cover art to work - cant find in this dir
10 fillMode: Image.PreserveAspectCrop
11 height: parent.height
12
13=== modified file 'common/CoverGrid.qml'
14--- common/CoverGrid.qml 2014-10-20 15:56:44 +0000
15+++ common/CoverGrid.qml 2014-10-21 03:20:36 +0000
16@@ -53,6 +53,7 @@
17 id: repeat
18 model: coverGrid.covers.length === 0 ? 1 : coverGrid.covers.length
19 delegate: Image {
20+ asynchronous: true
21 fillMode: Image.PreserveAspectCrop
22 height: coverGrid.size / (coverGrid.covers.length > 1 ? 2 : 1)
23 width: coverGrid.size / (coverGrid.covers.length > 2 && !(coverGrid.covers.length === 3 && index === 2) ? 2 : 1)

Subscribers

People subscribed via source and target branches