Ubuntu Music App

Code review comment for lp:~vthompson/music-app/lookup-file

  1. lookup-file
  2. Merge into trusty
Revision history for this message
Andrew Hayzen (ahayzen) wrote :

What would happen if album A was selected in the scope, the user changed the queue, and then album A was selected again. I think nothing would happen as the model would not Fill again?

Suggest blanking the filter at the end of onFilled and then inside onFilled wrap all the code in a check to ensure the filter is not blank.

review: Needs Fixing

« Back to merge proposal