Merge lp:~vthompson/music-app/fixes-1240610 into lp:music-app/trusty

Proposed by Victor Thompson
Status: Merged
Approved by: Victor Thompson
Approved revision: 216
Merged at revision: 216
Proposed branch: lp:~vthompson/music-app/fixes-1240610
Merge into: lp:music-app/trusty
Diff against target: 12 lines (+3/-0)
1 file modified
MusicNowPlaying.qml (+3/-0)
To merge this branch: bzr merge lp:~vthompson/music-app/fixes-1240610
Reviewer Review Type Date Requested Status
Andrew Hayzen Approve
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Review via email: mp+191474@code.launchpad.net

Commit message

* For last item in queue, fix snap to track

Description of the change

* For last item in queue, fix snap to track

To post a comment you must log in.
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
Andrew Hayzen (ahayzen) wrote :

Can you replace the ListItem.Standard with a transparent Rectangle so that it removes the extra spacer (horizontal grey bar) that is created at the bottom of the ListItem.

footer: Rectangle {
   color: "transparent"
   height: mainView.height - styleMusic.nowPlaying.expandedHeightCurrent + units.gu(8)
}

review: Needs Fixing
216. By Victor Thompson

Change footer to Item

Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
Andrew Hayzen (ahayzen) wrote :

Awesome :)

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'MusicNowPlaying.qml'
2--- MusicNowPlaying.qml 2013-10-16 15:05:42 +0000
3+++ MusicNowPlaying.qml 2013-10-16 19:01:50 +0000
4@@ -125,6 +125,9 @@
5 }
6 }
7 ]
8+ footer: Item {
9+ height: mainView.height - styleMusic.nowPlaying.expandedHeightCurrent + units.gu(8)
10+ }
11
12 property bool scrollLock: false
13

Subscribers

People subscribed via source and target branches

to status/vote changes: