Merge lp:~vthompson/music-app/fix-various-artists into lp:music-app/remix

Proposed by Victor Thompson
Status: Merged
Approved by: Andrew Hayzen
Approved revision: 753
Merged at revision: 753
Proposed branch: lp:~vthompson/music-app/fix-various-artists
Merge into: lp:music-app/remix
Diff against target: 12 lines (+1/-1)
1 file modified
common/SongsPage.qml (+1/-1)
To merge this branch: bzr merge lp:~vthompson/music-app/fix-various-artists
Reviewer Review Type Date Requested Status
Andrew Hayzen Approve
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Review via email: mp+242859@code.launchpad.net

Commit message

Use AlbumsModel albumArtist property to display Various Artist albums.

Description of the change

Use AlbumsModel albumArtist property to display Various Artist albums. Since mediascanner2 can handle if there is no albumArtist field explicitly set in the database.

To post a comment you must log in.
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Needs Fixing (continuous-integration)
753. By Victor Thompson

Implement the solution correctly

Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
Andrew Hayzen (ahayzen) wrote :

LGTM :)

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'common/SongsPage.qml'
2--- common/SongsPage.qml 2014-11-11 20:08:11 +0000
3+++ common/SongsPage.qml 2014-11-26 02:33:47 +0000
4@@ -43,7 +43,7 @@
5
6 property var page
7 property alias album: songsModel.album
8- property alias artist: songsModel.artist
9+ property alias artist: songsModel.albumArtist
10 property alias genre: songsModel.genre
11
12 property bool playlistChanged: false

Subscribers

People subscribed via source and target branches