Ubuntu Music App

Merge lp:~vthompson/music-app/fix-search-field-white-text into lp:music-app

  1. fix-search-field-white-text
  2. Merge into trunk
Proposed by Victor Thompson
Status: Merged
Approved by: Andrew Hayzen
Approved revision: 999
Merged at revision: 999
Proposed branch: lp:~vthompson/music-app/fix-search-field-white-text
Merge into: lp:music-app
Diff against target: 23 lines (+2/-0)
2 files modified
app/components/HeadState/SearchHeadState.qml (+1/-0)
debian/changelog (+1/-0)
To merge this branch: bzr merge lp:~vthompson/music-app/fix-search-field-white-text
Reviewer Review Type Date Requested Status
Andrew Hayzen Approve
Jenkins Bot continuous-integration Approve
Review via email: mp+291068@code.launchpad.net

Commit message

* Fix the Search TextField component color so the text is not invisible when field is not in focus

Description of the change

* Fix the Search TextField component color so the text is not invisible when field is not in focus

This should probably be reported in an SDK bug regarding the Suru theme when the TextField is not in focus. This is only a workaround.

To post a comment you must log in.
Revision history for this message
Jenkins Bot (ubuntu-core-apps-jenkins-bot) wrote :

PASSED: Continuous integration, rev:998
https://core-apps-jenkins.ubuntu.com/job/music-app-ci/102/
Executed test runs:
    None: https://core-apps-jenkins.ubuntu.com/job/generic-update-mp/850/console

Click here to trigger a rebuild:
https://core-apps-jenkins.ubuntu.com/job/music-app-ci/102/rebuild

review: Approve (continuous-integration)
lp:~vthompson/music-app/fix-search-field-white-text updated
999. By Victor Thompson

Merge and resolve conflict

Revision history for this message
Jenkins Bot (ubuntu-core-apps-jenkins-bot) wrote :

PASSED: Continuous integration, rev:999
https://core-apps-jenkins.ubuntu.com/job/music-app-ci/104/
Executed test runs:
    None: https://core-apps-jenkins.ubuntu.com/job/generic-update-mp/852/console

Click here to trigger a rebuild:
https://core-apps-jenkins.ubuntu.com/job/music-app-ci/104/rebuild

review: Approve (continuous-integration)
Revision history for this message
Andrew Hayzen (ahayzen) wrote :

LGTM :-)

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'app/components/HeadState/SearchHeadState.qml'
2--- app/components/HeadState/SearchHeadState.qml 2016-03-28 09:50:01 +0000
3+++ app/components/HeadState/SearchHeadState.qml 2016-04-06 03:27:08 +0000
4@@ -31,6 +31,7 @@
5 right: parent ? parent.right : undefined
6 verticalCenter: parent ? parent.verticalCenter : undefined
7 }
8+ color: UbuntuColors.ash
9 focus: true
10 hasClearButton: true
11 inputMethodHints: Qt.ImhNoPredictiveText
12
13=== modified file 'debian/changelog'
14--- debian/changelog 2016-03-28 09:50:01 +0000
15+++ debian/changelog 2016-04-06 03:27:08 +0000
16@@ -11,6 +11,7 @@
17 * Fix topMargin of the Playlists empty state so title is not obscurred (LP: #1538829).
18 * Fix fallback art when the it is linked to the Player's currentMeta (LP: #1549557).
19 * Update a number of components to work properly with new color palette in the SDK (LP: #1550096).
20+ * Fix the Search TextField component color so the text is not invisible when field is not in focus (LP: #1550096).
21
22 [ Andrew Hayzen ]
23 * Fix so that a press and hold cannot disable selection in the ContentHubExport.qml (LP: #1538838)

Subscribers

People subscribed via source and target branches