Merge lp:~vthompson/music-app/fix-orientation into lp:~ahayzen/music-app/refactor-pull-now-playing-sidebar
Proposed by
Victor Thompson
Status: | Merged |
---|---|
Approved by: | Andrew Hayzen |
Approved revision: | 854 |
Merged at revision: | 854 |
Proposed branch: | lp:~vthompson/music-app/fix-orientation |
Merge into: | lp:~ahayzen/music-app/refactor-pull-now-playing-sidebar |
Diff against target: |
14 lines (+2/-2) 1 file modified
app/music-app.qml (+2/-2) |
To merge this branch: | bzr merge lp:~vthompson/music-app/fix-orientation |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Andrew Hayzen | Approve | ||
Review via email: mp+265622@code.launchpad.net |
Commit message
Update orientation/
Description of the change
Update orientation/
Currently the solution in the MP doesn't work when things are rotated. I think we need to go back to the older way of determining that we are "landscape". Really what this means is that the height follows logically as you rotate the device so the app shouldn't need to know the orientation.
To post a comment you must log in.
Works well, I think we should be able to remove the import for the sensor as well? But I'll do that in my branch.