Merge lp:~vthompson/music-app/fix-ap-instructions into lp:music-app

Proposed by Victor Thompson
Status: Merged
Approved by: Andrew Hayzen
Approved revision: 891
Merged at revision: 894
Proposed branch: lp:~vthompson/music-app/fix-ap-instructions
Merge into: lp:music-app
Diff against target: 66 lines (+22/-9)
2 files modified
README.autopilot (+21/-9)
debian/changelog (+1/-0)
To merge this branch: bzr merge lp:~vthompson/music-app/fix-ap-instructions
Reviewer Review Type Date Requested Status
Andrew Hayzen Approve
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Review via email: mp+265218@code.launchpad.net

Commit message

* Fix typo in README.autopilot and clarify the instructions

Description of the change

* Fix typo in README.autopilot and clarify the instructions

While going through these instructions to document the steps for the Weather app, I noticed this typo.

To post a comment you must log in.
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :

PASSED: Continuous integration, rev:888
http://91.189.93.70:8080/job/music-app-ci/1343/
Executed test runs:
    SUCCESS: http://91.189.93.70:8080/job/music-app-vivid-amd64-ci/195

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/music-app-ci/1343/rebuild

review: Approve (continuous-integration)
889. By Victor Thompson

Add password param

Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :

PASSED: Continuous integration, rev:889
http://91.189.93.70:8080/job/music-app-ci/1344/
Executed test runs:
    SUCCESS: http://91.189.93.70:8080/job/music-app-vivid-amd64-ci/196

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/music-app-ci/1344/rebuild

review: Approve (continuous-integration)
Revision history for this message
Andrew Hayzen (ahayzen) wrote :

One inline note :-)

review: Needs Fixing
890. By Victor Thompson

Update instructions per weather app updates.

Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :

PASSED: Continuous integration, rev:890
http://91.189.93.70:8080/job/music-app-ci/1346/
Executed test runs:
    SUCCESS: http://91.189.93.70:8080/job/music-app-vivid-amd64-ci/198

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/music-app-ci/1346/rebuild

review: Approve (continuous-integration)
891. By Victor Thompson

Merge of trunk of resolve conflicts

Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :

PASSED: Continuous integration, rev:891
http://91.189.93.70:8080/job/music-app-ci/1354/
Executed test runs:
    SUCCESS: http://91.189.93.70:8080/job/music-app-vivid-amd64-ci/206

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/music-app-ci/1354/rebuild

review: Approve (continuous-integration)
Revision history for this message
Andrew Hayzen (ahayzen) wrote :

LGTM :-)

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'README.autopilot'
2--- README.autopilot 2015-05-13 23:51:26 +0000
3+++ README.autopilot 2015-08-04 23:44:56 +0000
4@@ -2,23 +2,26 @@
5
6 Music App follows a test driven development where autopilot tests are run before every merge into trunk. If you are submitting your bugfix/patch to the music app, please follow the following steps below to ensure that all tests pass before proposing a merge request.
7
8-If you are looking for more info about Autopilot or writing AP tests for the music app, here are some useful links to help you,
9-
10-- http://developer.ubuntu.com/api/devel/ubuntu-14.10/python/autopilot/
11-- http://developer.ubuntu.com/api/devel/ubuntu-14.10/python/autopilot-emulator/
12+If you are looking for more info about Autopilot or writing AP tests for the music app, here are some useful links to help you:
13+
14+- http://developer.ubuntu.com/start/quality
15+- https://developer.ubuntu.com/api/autopilot/python/1.5.0/
16+
17+For help and options on running tests, see:
18+
19+- https://developer.ubuntu.com/en/start/platform/guides/running-autopilot-tests/
20
21 ## Prerequisites
22
23 Install the following autopilot packages required to run the tests,
24-$ sudo apt-get install python-autopilot libautopilot-qt ubuntu-ui-toolkit-autopilot python3-autopilot-vis
25-
26+$ sudo apt-get install python3-autopilot libautopilot-qt ubuntu-ui-toolkit-autopilot python3-autopilot-vis
27
28 ## Running tests on the desktop
29
30 Using terminal:
31
32 * Branch the music app code, for example,
33- $ bzr branch lp:music-ap
34+ $ bzr branch lp:music-app
35
36 * Navigate to the tests/autopilot directory.
37 $ cd music-app/tests/autopilot
38@@ -46,5 +49,14 @@
39
40 Using autopkg:
41
42-1. navigate to the directory where the music-app branch is and run:
43- $ adt-run music-app --click=com.ubuntu.music --- ssh -s adb
44+* Branch the Music app code, for example,
45+ $ bzr branch lp:music-app
46+
47+* Navigate to the source directory.
48+ $ cd music-app
49+
50+* Build a click package
51+ $ click-buddy .
52+
53+* Run the tests on device (assumes only one click package in the directory)
54+ $ adt-run . *.click --- ssh -s adb -- -p <PASSWORD>
55
56=== modified file 'debian/changelog'
57--- debian/changelog 2015-07-26 22:43:31 +0000
58+++ debian/changelog 2015-08-04 23:44:56 +0000
59@@ -3,6 +3,7 @@
60 [ Victor Thompson ]
61 * Fix SongsView album art for albums and genres (LP: #1477366)
62 * Fix to allow the LibraryEmptyState to work again (LP: #1478162)
63+ * Fix typo in README.autopilot and clarify the instructions
64
65 [ Andrew Hayzen ]
66 * Fix for console errors when using the parent changed helpers

Subscribers

People subscribed via source and target branches