Merge lp:~vthompson/music-app/fix-animation into lp:music-app/trusty

Proposed by Victor Thompson
Status: Merged
Approved by: Victor Thompson
Approved revision: 612
Merged at revision: 612
Proposed branch: lp:~vthompson/music-app/fix-animation
Merge into: lp:music-app/trusty
Diff against target: 12 lines (+1/-1)
1 file modified
MusicNowPlaying.qml (+1/-1)
To merge this branch: bzr merge lp:~vthompson/music-app/fix-animation
Reviewer Review Type Date Requested Status
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Andrew Hayzen Approve
Review via email: mp+233290@code.launchpad.net

Commit message

Fix currently playing item transition.

Description of the change

Fix currently playing item transition. Revision #610 [1] introduced a small regression where the animation from a non-playing item to the currently playing item on the Now Playing page would clip as the animation takes place.

[1] http://bazaar.launchpad.net/~music-app-dev/music-app/trunk/revision/610

To post a comment you must log in.
Revision history for this message
Andrew Hayzen (ahayzen) wrote :

LGTM fixes the issue :)

review: Approve
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'MusicNowPlaying.qml'
2--- MusicNowPlaying.qml 2014-08-29 00:33:05 +0000
3+++ MusicNowPlaying.qml 2014-09-03 23:43:17 +0000
4@@ -315,7 +315,7 @@
5 name: "current"
6 PropertyChanges {
7 target: queueListItem
8- height: trackImage.height + (trackContainer.anchors.margins * 2)
9+ height: trackImage.size + (trackContainer.anchors.margins * 2)
10 }
11 PropertyChanges {
12 target: nowPlayingArtist

Subscribers

People subscribed via source and target branches

to status/vote changes: