Merge lp:~vthompson/music-app/fix-1538829-no-playlists-label into lp:music-app

Proposed by Victor Thompson
Status: Merged
Approved by: Victor Thompson
Approved revision: 982
Merged at revision: 989
Proposed branch: lp:~vthompson/music-app/fix-1538829-no-playlists-label
Merge into: lp:music-app
Diff against target: 26 lines (+4/-1)
2 files modified
app/components/PlaylistsEmptyState.qml (+3/-1)
debian/changelog (+1/-0)
To merge this branch: bzr merge lp:~vthompson/music-app/fix-1538829-no-playlists-label
Reviewer Review Type Date Requested Status
Jenkins Bot continuous-integration Approve
Andrew Hayzen Approve
Review via email: mp+287415@code.launchpad.net

Commit message

* Fix topMargin of the Playlists empty state so title is not obscurred

Description of the change

* Fix topMargin of the Playlists empty state so title is not obscurred

To post a comment you must log in.
Revision history for this message
Jenkins Bot (ubuntu-core-apps-jenkins-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Andrew Hayzen (ahayzen) wrote :

One inline comment.

review: Needs Information
Revision history for this message
Victor Thompson (vthompson) wrote :

Using the parent's verticalCenter also doesn't work--probably for the same reason centerIn isn't...

Revision history for this message
Andrew Hayzen (ahayzen) wrote :

OK, this will be good enough for now then :-)

review: Approve
Revision history for this message
Jenkins Bot (ubuntu-core-apps-jenkins-bot) wrote :

FAILED: Autolanding.
More details in the following jenkins job:
https://core-apps-jenkins.ubuntu.com/job/music-app-autolanding/89/
Executed test runs:
    None: https://core-apps-jenkins.ubuntu.com/job/generic-land-mp/5664/console

review: Needs Fixing (continuous-integration)
Revision history for this message
Jenkins Bot (ubuntu-core-apps-jenkins-bot) wrote :

FAILED: Autolanding.
More details in the following jenkins job:
https://core-apps-jenkins.ubuntu.com/job/music-app-autolanding/90/
Executed test runs:
    None: https://core-apps-jenkins.ubuntu.com/job/generic-land-mp/5679/console

review: Needs Fixing (continuous-integration)
982. By Victor Thompson

Merge of trunk and resolve conflicts.

Revision history for this message
Jenkins Bot (ubuntu-core-apps-jenkins-bot) wrote :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'app/components/PlaylistsEmptyState.qml'
2--- app/components/PlaylistsEmptyState.qml 2015-08-12 23:36:44 +0000
3+++ app/components/PlaylistsEmptyState.qml 2016-03-09 01:10:47 +0000
4@@ -24,7 +24,9 @@
5 Rectangle {
6 id: playlistsEmptyState
7 anchors {
8- fill: parent
9+ top: parent.top
10+ topMargin: units.gu(11.5)
11+ bottom: parent.bottom
12 }
13 color: mainView.backgroundColor
14
15
16=== modified file 'debian/changelog'
17--- debian/changelog 2016-02-28 01:51:17 +0000
18+++ debian/changelog 2016-03-09 01:10:47 +0000
19@@ -8,6 +8,7 @@
20 * Fix fallback image path in MusicListItem (LP: #1549580).
21 * Fix regression where AddToPlaylist.qml no long supports plural track counts (LP: #1550832).
22 * Remove offset from the top of AddToPlaylist.qml (LP: #1538832).
23+ * Fix topMargin of the Playlists empty state so title is not obscurred (LP: #1538829).
24
25 [ Andrew Hayzen ]
26 * Fix so that a press and hold cannot disable selection in the ContentHubExport.qml (LP: #1538838)

Subscribers

People subscribed via source and target branches