Merge lp:~vthompson/music-app/fix-1478162 into lp:music-app

Proposed by Victor Thompson
Status: Merged
Approved by: Andrew Hayzen
Approved revision: 890
Merged at revision: 889
Proposed branch: lp:~vthompson/music-app/fix-1478162
Merge into: lp:music-app
Diff against target: 25 lines (+3/-2)
2 files modified
app/components/Helpers/ContentHubHelper.qml (+1/-1)
debian/changelog (+2/-1)
To merge this branch: bzr merge lp:~vthompson/music-app/fix-1478162
Reviewer Review Type Date Requested Status
Andrew Hayzen Approve
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Review via email: mp+265885@code.launchpad.net

Commit message

* Fix to allow the LibraryEmptyState to work again

Description of the change

* Fix to allow the LibraryEmptyState to work again

A minor bug in the ContentHubHelper was causing the LibraryEmptyState to not work properly. It may have been causing other issues that we were working around. So things related to ContentHub should probably be retested for surface level failures.

I want this to land prior to releasing the next revision of the app to the app store.

To post a comment you must log in.
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :

PASSED: Continuous integration, rev:889
http://91.189.93.70:8080/job/music-app-ci/1349/
Executed test runs:
    SUCCESS: http://91.189.93.70:8080/job/music-app-vivid-amd64-ci/201

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/music-app-ci/1349/rebuild

review: Approve (continuous-integration)
lp:~vthompson/music-app/fix-1478162 updated
890. By Victor Thompson

update changelog

Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :

PASSED: Continuous integration, rev:890
http://91.189.93.70:8080/job/music-app-ci/1350/
Executed test runs:
    SUCCESS: http://91.189.93.70:8080/job/music-app-vivid-amd64-ci/202

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/music-app-ci/1350/rebuild

review: Approve (continuous-integration)
Revision history for this message
Andrew Hayzen (ahayzen) wrote :

Woops! Wonder how that happened. LGTM :-)

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'app/components/Helpers/ContentHubHelper.qml'
2--- app/components/Helpers/ContentHubHelper.qml 2015-06-29 23:50:12 +0000
3+++ app/components/Helpers/ContentHubHelper.qml 2015-07-25 04:43:04 +0000
4@@ -28,7 +28,7 @@
5 property var activeTransfer
6 property int importId: 0
7 property list<ContentItem> importItems
8- property bool processing: contentHubWaitForFile !== -1
9+ property bool processing: contentHubWaitForFile.processId !== -1
10
11 ContentTransferHint {
12 anchors {
13
14=== modified file 'debian/changelog'
15--- debian/changelog 2015-07-24 02:09:59 +0000
16+++ debian/changelog 2015-07-25 04:43:04 +0000
17@@ -1,7 +1,8 @@
18 music-app (2.2ubuntu1) UNRELEASED; urgency=medium
19
20 [ Victor Thompson ]
21- * Fix SongsView album art for albums and genres
22+ * Fix SongsView album art for albums and genres (LP: #1477366)
23+ * Fix to allow the LibraryEmptyState to work again (LP: #1478162)
24
25 -- Victor Thompson <victor.thompson@gmail.com> Thu, 23 Jul 2015 21:08:38 -0500
26

Subscribers

People subscribed via source and target branches