Merge lp:~vthompson/music-app/fix-1477366-SongsView-album-art into lp:music-app

Proposed by Victor Thompson
Status: Merged
Approved by: Andrew Hayzen
Approved revision: no longer in the source branch.
Merged at revision: 888
Proposed branch: lp:~vthompson/music-app/fix-1477366-SongsView-album-art
Merge into: lp:music-app
Diff against target: 32 lines (+13/-1)
2 files modified
app/ui/SongsView.qml (+6/-1)
debian/changelog (+7/-0)
To merge this branch: bzr merge lp:~vthompson/music-app/fix-1477366-SongsView-album-art
Reviewer Review Type Date Requested Status
Andrew Hayzen Approve
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Review via email: mp+265623@code.launchpad.net

Commit message

Fix SongsView album art for albums and genres

Description of the change

Fix SongsView album art for albums and genres

When the count changes we should NOT get the album/genre cover arts from the Playlist db... sigh.

To post a comment you must log in.
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :

PASSED: Continuous integration, rev:888
http://91.189.93.70:8080/job/music-app-ci/1347/
Executed test runs:
    SUCCESS: http://91.189.93.70:8080/job/music-app-vivid-amd64-ci/199

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/music-app-ci/1347/rebuild

review: Approve (continuous-integration)
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :

PASSED: Continuous integration, rev:889
http://91.189.93.70:8080/job/music-app-ci/1348/
Executed test runs:
    SUCCESS: http://91.189.93.70:8080/job/music-app-vivid-amd64-ci/200

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/music-app-ci/1348/rebuild

review: Approve (continuous-integration)
Revision history for this message
Andrew Hayzen (ahayzen) wrote :

LGTM :-)

review: Approve
888. By Victor Thompson

Fix SongsView album art for albums and genres. Fixes: https://bugs.launchpad.net/bugs/1477366.

Approved by Andrew Hayzen, Ubuntu Phone Apps Jenkins Bot.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'app/ui/SongsView.qml'
2--- app/ui/SongsView.qml 2015-07-17 22:35:11 +0000
3+++ app/ui/SongsView.qml 2015-07-24 02:10:27 +0000
4@@ -187,7 +187,12 @@
5 objectName: "songspage-listview"
6 width: parent.width
7
8- onCountChanged: songStackPage.covers = Playlists.getPlaylistCovers(songStackPage.line2)
9+ onCountChanged: {
10+ // If the number of songs in this playlist has changed, refresh the cover art
11+ if (songStackPage.line1 === i18n.tr("Playlist")) {
12+ songStackPage.covers = Playlists.getPlaylistCovers(songStackPage.line2)
13+ }
14+ }
15
16 header: BlurredHeader {
17 id: blurredHeader
18
19=== modified file 'debian/changelog'
20--- debian/changelog 2015-06-27 20:51:23 +0000
21+++ debian/changelog 2015-07-24 02:10:27 +0000
22@@ -1,3 +1,10 @@
23+music-app (2.2ubuntu1) UNRELEASED; urgency=medium
24+
25+ [ Victor Thompson ]
26+ * Fix SongsView album art for albums and genres
27+
28+ -- Victor Thompson <victor.thompson@gmail.com> Thu, 23 Jul 2015 21:08:38 -0500
29+
30 music-app (2.2) vivid; urgency=medium
31 [ Andrew Hayzen ]
32 * Bump framework to 15.04

Subscribers

People subscribed via source and target branches