Merge lp:~vthompson/music-app/fix-1475768 into lp:music-app

Proposed by Victor Thompson
Status: Merged
Approved by: Victor Thompson
Approved revision: 887
Merged at revision: 887
Proposed branch: lp:~vthompson/music-app/fix-1475768
Merge into: lp:music-app
Diff against target: 33 lines (+3/-6)
1 file modified
app/ui/SongsView.qml (+3/-6)
To merge this branch: bzr merge lp:~vthompson/music-app/fix-1475768
Reviewer Review Type Date Requested Status
Andrew Hayzen Approve
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Review via email: mp+265185@code.launchpad.net

Commit message

Refresh cover art when model count changes

Description of the change

Refresh cover art when model count changes

To post a comment you must log in.
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :

PASSED: Continuous integration, rev:887
http://91.189.93.70:8080/job/music-app-ci/1339/
Executed test runs:
    SUCCESS: http://91.189.93.70:8080/job/music-app-vivid-amd64-ci/191

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/music-app-ci/1339/rebuild

review: Approve (continuous-integration)
Revision history for this message
Andrew Hayzen (ahayzen) wrote :

LGTM, do you want to add a changelog item for this or start after this MP, as per our new changelog policy :-)

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'app/ui/SongsView.qml'
2--- app/ui/SongsView.qml 2015-07-01 01:42:04 +0000
3+++ app/ui/SongsView.qml 2015-07-17 22:36:26 +0000
4@@ -164,9 +164,6 @@
5 playlistChangedHelper() // update recent/playlist models
6
7 albumTracksModel.filterPlaylistTracks(songStackPage.line2)
8-
9- // refresh cover art
10- songStackPage.covers = Playlists.getPlaylistCovers(songStackPage.line2)
11 }
12 }
13 ]
14@@ -189,6 +186,9 @@
15 model: isAlbum ? songsModel : albumTracksModel.model
16 objectName: "songspage-listview"
17 width: parent.width
18+
19+ onCountChanged: songStackPage.covers = Playlists.getPlaylistCovers(songStackPage.line2)
20+
21 header: BlurredHeader {
22 id: blurredHeader
23 rightColumn: Column {
24@@ -357,9 +357,6 @@
25 playlistChangedHelper() // update recent/playlist models
26
27 albumTracksModel.filterPlaylistTracks(songStackPage.line2)
28-
29- // refresh cover art
30- songStackPage.covers = Playlists.getPlaylistCovers(songStackPage.line2)
31 }
32 }
33 }

Subscribers

People subscribed via source and target branches