Merge lp:~vthompson/music-app/fix-1415697-revert-trackClicked-change into lp:music-app/remix

Proposed by Victor Thompson
Status: Merged
Approved by: Andrew Hayzen
Approved revision: 818
Merged at revision: 819
Proposed branch: lp:~vthompson/music-app/fix-1415697-revert-trackClicked-change
Merge into: lp:music-app/remix
Diff against target: 13 lines (+0/-3)
1 file modified
music-app.qml (+0/-3)
To merge this branch: bzr merge lp:~vthompson/music-app/fix-1415697-revert-trackClicked-change
Reviewer Review Type Date Requested Status
Andrew Hayzen Approve
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Review via email: mp+247932@code.launchpad.net

Commit message

* Revert trackClicked() change to stop queue loader

Description of the change

* Revert trackClicked() change to stop queue loader

There might be additional changes we'll want to make to fix the original issue, but in the least reverting this code change fixes the issue.

To post a comment you must log in.
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
Andrew Hayzen (ahayzen) wrote :

Seems to fix the issue, not sure what was causing it yet though :/

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'music-app.qml'
2--- music-app.qml 2015-01-26 03:26:39 +0000
3+++ music-app.qml 2015-01-29 02:46:05 +0000
4@@ -654,9 +654,6 @@
5 }
6
7 function trackClicked(model, index, play, clear) {
8- // Stop queue loading in the background
9- queueLoaderWorker.canLoad = false
10-
11 // TODO: remove once playlists uses U1DB
12 if (model.hasOwnProperty("linkLibraryListModel")) {
13 model = model.linkLibraryListModel;

Subscribers

People subscribed via source and target branches