Ubuntu Music App

Merge lp:~vthompson/music-app/fix-1343724 into lp:music-app/trusty

  1. fix-1343724
  2. Merge into trusty
Proposed by Victor Thompson
Status: Merged
Approved by: Andrew Hayzen
Approved revision: 525
Merged at revision: 530
Proposed branch: lp:~vthompson/music-app/fix-1343724
Merge into: lp:music-app/trusty
Diff against target: 12 lines (+1/-1)
1 file modified
common/SongsPage.qml (+1/-1)
To merge this branch: bzr merge lp:~vthompson/music-app/fix-1343724
Reviewer Review Type Date Requested Status
Andrew Hayzen Approve
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Review via email: mp+227278@code.launchpad.net

Commit message

Always get album date

Description of the change

Always get album date. When the SongsPage is initially loaded the date is blank, but it needs to be subsequently reset when a new album is selected.

To post a comment you must log in.
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :

PASSED: Continuous integration, rev:525
http://91.189.93.70:8080/job/music-app-ci/945/
Executed test runs:
    SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-utopic/1068
        deb: http://91.189.93.70:8080/job/generic-mediumtests-utopic/1068/artifact/work/output/*zip*/output.zip
    SUCCESS: http://91.189.93.70:8080/job/music-app-utopic-amd64-ci/169

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/music-app-ci/945/rebuild

review: Approve (continuous-integration)
Revision history for this message
Andrew Hayzen (ahayzen) wrote :

Nice catch :)

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'common/SongsPage.qml'
2--- common/SongsPage.qml 2014-07-11 22:29:21 +0000
3+++ common/SongsPage.qml 2014-07-18 03:05:50 +0000
4@@ -286,7 +286,7 @@
5 }
6
7 Component.onCompleted: {
8- if (model.date !== undefined && songStackPage.year === "")
9+ if (model.date !== undefined)
10 {
11 songStackPage.file = model.filename;
12 songStackPage.year = new Date(model.date).toLocaleString(Qt.locale(),'yyyy');

Subscribers

People subscribed via source and target branches

to status/vote changes: