Merge lp:~vthompson/music-app/consistent-icons into lp:music-app/trusty

Proposed by Victor Thompson
Status: Merged
Approved by: Andrew Hayzen
Approved revision: 522
Merged at revision: 533
Proposed branch: lp:~vthompson/music-app/consistent-icons
Merge into: lp:music-app/trusty
Diff against target: 267 lines (+20/-109)
7 files modified
MusicPlaylists.qml (+1/-1)
MusicaddtoPlaylist.qml (+1/-1)
common/AlbumsPage.qml (+10/-8)
common/ExpanderItems/AddToPlaylist.qml (+1/-1)
common/ExpanderItems/AddToQueue.qml (+3/-2)
common/SongsPage.qml (+4/-4)
images/add.svg (+0/-92)
To merge this branch: bzr merge lp:~vthompson/music-app/consistent-icons
Reviewer Review Type Date Requested Status
Andrew Hayzen Approve
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Review via email: mp+226597@code.launchpad.net

Commit message

* Make icons consistent
* Remove some unused icons
* Use Icon component when possible

Description of the change

* Make icons consistent
* Remove some unused icons
* Use Icon component when possible

To post a comment you must log in.
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
Andrew Hayzen (ahayzen) wrote :

Awesome looks much better :)

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'MusicPlaylists.qml'
2--- MusicPlaylists.qml 2014-07-11 22:29:21 +0000
3+++ MusicPlaylists.qml 2014-07-13 00:18:16 +0000
4@@ -49,7 +49,7 @@
5 action: Action {
6 objectName: "newplaylistButton"
7 text: i18n.tr("New playlist")
8- iconSource: "images/add.svg"
9+ iconName: "add"
10 onTriggered: {
11 customdebug("New playlist.")
12 PopupUtils.open(newPlaylistDialog, mainView)
13
14=== modified file 'MusicaddtoPlaylist.qml'
15--- MusicaddtoPlaylist.qml 2014-07-11 22:29:21 +0000
16+++ MusicaddtoPlaylist.qml 2014-07-13 00:18:16 +0000
17@@ -45,7 +45,7 @@
18 action: Action {
19 objectName: "newplaylistButton"
20 text: i18n.tr("New playlist")
21- iconSource: "images/add.svg"
22+ iconName: "add"
23 onTriggered: {
24 customdebug("New playlist.")
25 PopupUtils.open(newPlaylistDialog, mainView)
26
27=== modified file 'common/AlbumsPage.qml'
28--- common/AlbumsPage.qml 2014-07-09 03:16:28 +0000
29+++ common/AlbumsPage.qml 2014-07-13 00:18:16 +0000
30@@ -145,10 +145,11 @@
31 color: "transparent"
32 height: units.gu(4)
33 width: units.gu(10)
34- Image {
35+ Icon {
36 id: playTrack
37 anchors.verticalCenter: parent.verticalCenter
38- source: "../images/add-to-playback.png"
39+ name: "media-playback-start"
40+ color: styleMusic.common.white
41 height: styleMusic.common.expandedItem
42 width: styleMusic.common.expandedItem
43 }
44@@ -187,11 +188,12 @@
45 color: "transparent"
46 height: units.gu(4)
47 width: units.gu(15)
48- Image {
49+ Icon {
50 id: queueAll
51 objectName: "albumpage-queue-all"
52 anchors.verticalCenter: parent.verticalCenter
53- source: "../images/add.svg"
54+ name: "add"
55+ color: styleMusic.common.white
56 height: styleMusic.common.expandedItem
57 width: styleMusic.common.expandedItem
58 }
59@@ -337,11 +339,11 @@
60 color: "transparent"
61 height: units.gu(3)
62 width: units.gu(15)
63- Image {
64+ Icon {
65 id: playTrack
66 objectName: "albumpage-playtrack"
67 anchors.verticalCenter: parent.verticalCenter
68- source: "../images/add-to-playback.png"
69+ name: "media-playback-start"
70 height: styleMusic.common.expandedItem
71 width: styleMusic.common.expandedItem
72 }
73@@ -377,11 +379,11 @@
74 color: "transparent"
75 height: units.gu(3)
76 width: units.gu(15)
77- Image {
78+ Icon {
79 id: queueTrack
80 objectName: "albumpage-queuetrack"
81 anchors.verticalCenter: parent.verticalCenter
82- source: "../images/add.svg"
83+ name: "add"
84 height: styleMusic.common.expandedItem
85 width: styleMusic.common.expandedItem
86 }
87
88=== modified file 'common/ExpanderItems/AddToPlaylist.qml'
89--- common/ExpanderItems/AddToPlaylist.qml 2014-06-19 21:16:33 +0000
90+++ common/ExpanderItems/AddToPlaylist.qml 2014-07-13 00:18:16 +0000
91@@ -30,7 +30,7 @@
92 id: playlistTrack
93 anchors.verticalCenter: parent.verticalCenter
94 color: styleMusic.common.white
95- name: "add"
96+ name: "add-to-playlist"
97 height: styleMusic.common.expandedItem
98 width: styleMusic.common.expandedItem
99 }
100
101=== modified file 'common/ExpanderItems/AddToQueue.qml'
102--- common/ExpanderItems/AddToQueue.qml 2014-05-10 19:11:33 +0000
103+++ common/ExpanderItems/AddToQueue.qml 2014-07-13 00:18:16 +0000
104@@ -25,10 +25,11 @@
105 color: "transparent"
106 height: styleMusic.common.expandHeight
107 width: units.gu(15)
108- Image {
109+ Icon {
110 id: queueTrack
111 anchors.verticalCenter: parent.verticalCenter
112- source: "../../images/queue.png"
113+ color: styleMusic.common.white
114+ name: "add"
115 height: styleMusic.common.expandedItem
116 width: styleMusic.common.expandedItem
117 }
118
119=== modified file 'common/SongsPage.qml'
120--- common/SongsPage.qml 2014-07-11 22:29:21 +0000
121+++ common/SongsPage.qml 2014-07-13 00:18:16 +0000
122@@ -132,11 +132,11 @@
123 color: "transparent"
124 height: units.gu(4)
125 width: units.gu(15)
126- Image {
127+ Icon {
128 id: playTrack
129 objectName: "songspage-playtrack"
130 anchors.verticalCenter: parent.verticalCenter
131- source: "../images/add-to-playback.png"
132+ name: "media-playback-start"
133 height: styleMusic.common.expandedItem
134 width: styleMusic.common.expandedItem
135 }
136@@ -179,11 +179,11 @@
137 color: "transparent"
138 height: units.gu(4)
139 width: units.gu(15)
140- Image {
141+ Icon {
142 id: queueAll
143 objectName: "songspage-queue-all"
144 anchors.verticalCenter: parent.verticalCenter
145- source: "../images/add.svg"
146+ name: "add"
147 height: styleMusic.common.expandedItem
148 width: styleMusic.common.expandedItem
149 }
150
151=== removed file 'images/add-to-playback.png'
152Binary files images/add-to-playback.png 2013-07-08 16:11:16 +0000 and images/add-to-playback.png 1970-01-01 00:00:00 +0000 differ
153=== removed file 'images/add-to-playlist.png'
154Binary files images/add-to-playlist.png 2013-07-08 16:11:16 +0000 and images/add-to-playlist.png 1970-01-01 00:00:00 +0000 differ
155=== removed file 'images/add.svg'
156--- images/add.svg 2013-09-01 13:46:11 +0000
157+++ images/add.svg 1970-01-01 00:00:00 +0000
158@@ -1,92 +0,0 @@
159-<?xml version="1.0" encoding="UTF-8" standalone="no"?>
160-<!-- Created with Inkscape (http://www.inkscape.org/) -->
161-
162-<svg
163- xmlns:dc="http://purl.org/dc/elements/1.1/"
164- xmlns:cc="http://creativecommons.org/ns#"
165- xmlns:rdf="http://www.w3.org/1999/02/22-rdf-syntax-ns#"
166- xmlns:svg="http://www.w3.org/2000/svg"
167- xmlns="http://www.w3.org/2000/svg"
168- xmlns:sodipodi="http://sodipodi.sourceforge.net/DTD/sodipodi-0.dtd"
169- xmlns:inkscape="http://www.inkscape.org/namespaces/inkscape"
170- width="90"
171- height="90"
172- id="svg3140"
173- version="1.1"
174- inkscape:version="0.48.3.1 r9886"
175- sodipodi:docname="add@30.svg">
176- <defs
177- id="defs3142" />
178- <sodipodi:namedview
179- id="base"
180- pagecolor="#ffffff"
181- bordercolor="#666666"
182- borderopacity="1.0"
183- inkscape:pageopacity="0.0"
184- inkscape:pageshadow="2"
185- inkscape:zoom="9.9475983"
186- inkscape:cx="35.802612"
187- inkscape:cy="30.102725"
188- inkscape:document-units="px"
189- inkscape:current-layer="layer1"
190- showgrid="true"
191- inkscape:window-width="1920"
192- inkscape:window-height="1029"
193- inkscape:window-x="0"
194- inkscape:window-y="24"
195- inkscape:window-maximized="1"
196- fit-margin-top="0"
197- fit-margin-left="0"
198- fit-margin-right="0"
199- fit-margin-bottom="0">
200- <inkscape:grid
201- type="xygrid"
202- id="grid3178"
203- empspacing="6"
204- visible="true"
205- enabled="true"
206- snapvisiblegridlinesonly="true"
207- originx="0px"
208- originy="-1.7382813e-05px" />
209- </sodipodi:namedview>
210- <metadata
211- id="metadata3145">
212- <rdf:RDF>
213- <cc:Work
214- rdf:about="">
215- <dc:format>image/svg+xml</dc:format>
216- <dc:type
217- rdf:resource="http://purl.org/dc/dcmitype/StillImage" />
218- <dc:title />
219- </cc:Work>
220- </rdf:RDF>
221- </metadata>
222- <g
223- inkscape:label="Layer 1"
224- inkscape:groupmode="layer"
225- id="layer1"
226- transform="translate(0,-962.36218)">
227- <rect
228- style="color:#000000;fill:none;stroke:none;stroke-width:7.5;marker:none;visibility:visible;display:inline;overflow:visible;enable-background:accumulate"
229- id="rect4198"
230- width="90"
231- height="90"
232- x="0"
233- y="962.36218" />
234- <rect
235- style="color:#000000;fill:#808080;fill-opacity:1;fill-rule:nonzero;stroke:none;stroke-width:7.5;marker:none;visibility:visible;display:inline;overflow:visible;enable-background:accumulate"
236- id="rect3978"
237- width="12"
238- height="78.00013"
239- x="39"
240- y="968.36212" />
241- <rect
242- transform="matrix(0,1,-1,0,0,0)"
243- y="-84"
244- x="1001.3622"
245- height="77.999985"
246- width="11.999976"
247- id="rect3998"
248- style="color:#000000;fill:#808080;fill-opacity:1;fill-rule:nonzero;stroke:none;stroke-width:7.5;marker:none;visibility:visible;display:inline;overflow:visible;enable-background:accumulate" />
249- </g>
250-</svg>
251
252=== removed file 'images/favourite.png'
253Binary files images/favourite.png 2013-07-08 16:11:16 +0000 and images/favourite.png 1970-01-01 00:00:00 +0000 differ
254=== removed file 'images/icon_settings@20.png'
255Binary files images/icon_settings@20.png 2013-05-08 13:13:37 +0000 and images/icon_settings@20.png 1970-01-01 00:00:00 +0000 differ
256=== removed file 'images/icon_share@20.png'
257Binary files images/icon_share@20.png 2013-05-08 13:13:37 +0000 and images/icon_share@20.png 1970-01-01 00:00:00 +0000 differ
258=== removed file 'images/no-favourite.png'
259Binary files images/no-favourite.png 2013-07-08 16:11:16 +0000 and images/no-favourite.png 1970-01-01 00:00:00 +0000 differ
260=== removed file 'images/playlist.png'
261Binary files images/playlist.png 2013-07-24 03:15:19 +0000 and images/playlist.png 1970-01-01 00:00:00 +0000 differ
262=== removed file 'images/queue.png'
263Binary files images/queue.png 2013-10-15 19:31:26 +0000 and images/queue.png 1970-01-01 00:00:00 +0000 differ
264=== removed file 'images/select-press.png'
265Binary files images/select-press.png 2013-07-08 16:11:16 +0000 and images/select-press.png 1970-01-01 00:00:00 +0000 differ
266=== removed file 'images/select.png'
267Binary files images/select.png 2013-07-08 16:11:16 +0000 and images/select.png 1970-01-01 00:00:00 +0000 differ

Subscribers

People subscribed via source and target branches

to status/vote changes: