Merge lp:~vthompson/music-app/change-nowplaying-queue-toggle-icon into lp:music-app/remix

Proposed by Victor Thompson
Status: Merged
Approved by: Andrew Hayzen
Approved revision: 756
Merged at revision: 787
Proposed branch: lp:~vthompson/music-app/change-nowplaying-queue-toggle-icon
Merge into: lp:music-app/remix
Diff against target: 12 lines (+1/-1)
1 file modified
MusicNowPlaying.qml (+1/-1)
To merge this branch: bzr merge lp:~vthompson/music-app/change-nowplaying-queue-toggle-icon
Reviewer Review Type Date Requested Status
Andrew Hayzen Approve
Victor Thompson Approve
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Review via email: mp+243481@code.launchpad.net

Commit message

* Change Now Playing/Queue toggle button.

Description of the change

* Change Now Playing/Queue toggle button.

Now Playing toggle to Queue: http://i.imgur.com/0lT8YwO.png
Queue toggle to Now Playing: http://i.imgur.com/kkcJKWc.png

To post a comment you must log in.
Revision history for this message
Victor Thompson (vthompson) wrote :

#blocked Design input

Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Approve (continuous-integration)
756. By Victor Thompson

merge of trunk

Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
Victor Thompson (vthompson) wrote :

This should be ready to land given design input.

review: Approve
Revision history for this message
Victor Thompson (vthompson) wrote :

#unblocked

Revision history for this message
Andrew Hayzen (ahayzen) wrote :

Nice, looks much better :)

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'MusicNowPlaying.qml'
2--- MusicNowPlaying.qml 2015-01-10 17:36:58 +0000
3+++ MusicNowPlaying.qml 2015-01-14 05:07:45 +0000
4@@ -79,7 +79,7 @@
5 actions: [
6 Action {
7 objectName: "toggleView"
8- iconName: "swap"
9+ iconName: isListView ? "stock_image" : "view-list-symbolic"
10 onTriggered: {
11 isListView = !isListView
12 }

Subscribers

People subscribed via source and target branches