Ubuntu Music App

Merge lp:~vthompson/music-app/change-active-listitem-action-to-blue into lp:music-app/remix

  1. change-active-listitem-action-to-blue
  2. Merge into remix
Proposed by Victor Thompson
Status: Merged
Approved by: Andrew Hayzen
Approved revision: 745
Merged at revision: 759
Proposed branch: lp:~vthompson/music-app/change-active-listitem-action-to-blue
Merge into: lp:music-app/remix
Diff against target: 12 lines (+1/-1)
1 file modified
common/ListItemWithActions.qml (+1/-1)
To merge this branch: bzr merge lp:~vthompson/music-app/change-active-listitem-action-to-blue
Reviewer Review Type Date Requested Status
Andrew Hayzen Approve
Jouni Helminen (community) Approve
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Review via email: mp+242289@code.launchpad.net

Commit message

Change the active ListItem action to Ubuntu blue.

Description of the change

This might need design review, but I'd assume this is the proper change. There may also be Dialog changes related to playlists that could be made, but those views are currently being redesigned.

To post a comment you must log in.
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :

PASSED: Continuous integration, rev:745
http://91.189.93.70:8080/job/music-app-ci/1159/
Executed test runs:
    SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-vivid/325
        deb: http://91.189.93.70:8080/job/generic-mediumtests-vivid/325/artifact/work/output/*zip*/output.zip
    SUCCESS: http://91.189.93.70:8080/job/music-app-vivid-amd64-ci/11

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/music-app-ci/1159/rebuild

review: Approve (continuous-integration)
Revision history for this message
Andrew Hayzen (ahayzen) wrote :

#blocked needs design input

Revision history for this message
Jouni Helminen (jounihelminen) wrote :

sounds good, let's land

review: Approve
Revision history for this message
Andrew Hayzen (ahayzen) wrote :

LGTM :)

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'common/ListItemWithActions.qml'
2--- common/ListItemWithActions.qml 2014-11-15 20:58:52 +0000
3+++ common/ListItemWithActions.qml 2014-11-20 01:11:01 +0000
4@@ -405,7 +405,7 @@
5 width: units.gu(3)
6 height: units.gu(3)
7 name: modelData.iconName
8- color: root.activeAction === modelData ? UbuntuColors.orange : styleMusic.common.white // CUSTOM
9+ color: root.activeAction === modelData ? UbuntuColors.blue : styleMusic.common.white // CUSTOM
10
11 property bool primed: false // CUSTOM
12 }

Subscribers

People subscribed via source and target branches