Merge lp:~vthompson/music-app/allow-current-to-resize into lp:music-app/trusty
Status: | Merged |
---|---|
Approved by: | Andrew Hayzen |
Approved revision: | 605 |
Merged at revision: | 610 |
Proposed branch: | lp:~vthompson/music-app/allow-current-to-resize |
Merge into: | lp:music-app/trusty |
Diff against target: |
25 lines (+6/-2) 1 file modified
MusicNowPlaying.qml (+6/-2) |
To merge this branch: | bzr merge lp:~vthompson/music-app/allow-current-to-resize |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Ubuntu Phone Apps Jenkins Bot | continuous-integration | Approve | |
Andrew Hayzen | Approve | ||
Review via email: mp+232659@code.launchpad.net |
Commit message
Allow currently playing item to resize in narrow mode.
Description of the change
Allow currently playing item to resize in narrow mode. With devices of varying sizes the currently playing item in the Now Playing page needs to be able to dynmically change it's size. The change here, allows this item to before almost as large as the view, but only when in narrow mode. Right now, I'm of the opinion that any device that is in narrow or phone mode should behave this way. This includes the Nexus 7, which once the the app uses better cover art, won't look so bad.
Nexus 4 before: http://
Nexus 4 after: http://
Nexus 7 before: http://
Nexus 7 after: http://
FAILED: Continuous integration, rev:605 91.189. 93.70:8080/ job/music- app-ci/ 1081/ 91.189. 93.70:8080/ job/generic- mediumtests- utopic/ 1731 91.189. 93.70:8080/ job/generic- mediumtests- utopic/ 1731/artifact/ work/output/ *zip*/output. zip 91.189. 93.70:8080/ job/music- app-utopic- amd64-ci/ 305
http://
Executed test runs:
UNSTABLE: http://
deb: http://
SUCCESS: http://
Click here to trigger a rebuild: 91.189. 93.70:8080/ job/music- app-ci/ 1081/rebuild
http://