Merge lp:~vthompson/music-app/allow-current-to-resize into lp:music-app/trusty

Proposed by Victor Thompson
Status: Merged
Approved by: Andrew Hayzen
Approved revision: 605
Merged at revision: 610
Proposed branch: lp:~vthompson/music-app/allow-current-to-resize
Merge into: lp:music-app/trusty
Diff against target: 25 lines (+6/-2)
1 file modified
MusicNowPlaying.qml (+6/-2)
To merge this branch: bzr merge lp:~vthompson/music-app/allow-current-to-resize
Reviewer Review Type Date Requested Status
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Andrew Hayzen Approve
Review via email: mp+232659@code.launchpad.net

Commit message

Allow currently playing item to resize in narrow mode.

Description of the change

Allow currently playing item to resize in narrow mode. With devices of varying sizes the currently playing item in the Now Playing page needs to be able to dynmically change it's size. The change here, allows this item to before almost as large as the view, but only when in narrow mode. Right now, I'm of the opinion that any device that is in narrow or phone mode should behave this way. This includes the Nexus 7, which once the the app uses better cover art, won't look so bad.

Nexus 4 before: http://i.imgur.com/CVAI4Bq.png
Nexus 4 after: http://i.imgur.com/AuJd8A4.png

Nexus 7 before: http://i.imgur.com/nlf2lGB.png
Nexus 7 after: http://i.imgur.com/eEnspdo.png

To post a comment you must log in.
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Andrew Hayzen (ahayzen) wrote :

#blocked bug 1363314

Revision history for this message
Andrew Hayzen (ahayzen) wrote :

Awesome looks good :)

review: Approve
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'MusicNowPlaying.qml'
2--- MusicNowPlaying.qml 2014-08-21 23:15:34 +0000
3+++ MusicNowPlaying.qml 2014-08-29 00:36:46 +0000
4@@ -213,7 +213,11 @@
5 leftMargin: units.gu(1.5)
6 }
7 count: 1
8- size: (queueListItem.state === "current" ? queuelist.currentHeight : queuelist.normalHeight) - units.gu(2)
9+ size: (queueListItem.state === "current"
10+ ? (mainView.wideAspect
11+ ? queuelist.currentHeight
12+ : mainView.width - (trackImage.anchors.leftMargin * 2))
13+ : queuelist.normalHeight) - units.gu(2)
14 covers: [{author: model.author, album: model.album}]
15
16 spacing: units.gu(2)
17@@ -311,7 +315,7 @@
18 name: "current"
19 PropertyChanges {
20 target: queueListItem
21- height: queuelist.currentHeight
22+ height: trackImage.height + (trackContainer.anchors.margins * 2)
23 }
24 PropertyChanges {
25 target: nowPlayingArtist

Subscribers

People subscribed via source and target branches

to status/vote changes: