Merge lp:~vthompson/music-app/adjust-transparent-bg-height into lp:music-app/trusty

Proposed by Victor Thompson
Status: Merged
Approved by: Victor Thompson
Approved revision: 571
Merged at revision: 579
Proposed branch: lp:~vthompson/music-app/adjust-transparent-bg-height
Merge into: lp:music-app/trusty
Diff against target: 65 lines (+6/-6)
3 files modified
MusicAlbums.qml (+1/-1)
MusicStart.qml (+3/-3)
common/AlbumsPage.qml (+2/-2)
To merge this branch: bzr merge lp:~vthompson/music-app/adjust-transparent-bg-height
Reviewer Review Type Date Requested Status
Andrew Hayzen Approve
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Review via email: mp+230917@code.launchpad.net

Commit message

* Adjust the size of the transparent background for a label.

Description of the change

Adjust the size of the transparent background for a label. Currently the top of the background and the label are too close. This MP adjusts some of the ones that seem problematic.

To post a comment you must log in.
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
Andrew Hayzen (ahayzen) wrote :

Looks good :)

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'MusicAlbums.qml'
2--- MusicAlbums.qml 2014-08-09 22:52:40 +0000
3+++ MusicAlbums.qml 2014-08-15 01:51:59 +0000
4@@ -97,7 +97,7 @@
5 left: parent.left
6 right: parent.right
7 }
8- height: units.gu(5)
9+ height: units.gu(6)
10 clip: true
11 UbuntuShape{
12 anchors {
13
14=== modified file 'MusicStart.qml'
15--- MusicStart.qml 2014-08-14 18:06:55 +0000
16+++ MusicStart.qml 2014-08-15 01:51:59 +0000
17@@ -144,7 +144,7 @@
18 left: parent.left
19 right: parent.right
20 }
21- height: units.gu(5)
22+ height: units.gu(6)
23 clip: true
24 UbuntuShape{
25 anchors {
26@@ -324,7 +324,7 @@
27 left: parent.left
28 right: parent.right
29 }
30- height: units.gu(5)
31+ height: units.gu(5.5)
32 clip: true
33 UbuntuShape{
34 anchors {
35@@ -458,7 +458,7 @@
36 left: parent.left
37 right: parent.right
38 }
39- height: units.gu(5)
40+ height: units.gu(6)
41 clip: true
42 UbuntuShape{
43 anchors {
44
45=== modified file 'common/AlbumsPage.qml'
46--- common/AlbumsPage.qml 2014-08-09 22:52:40 +0000
47+++ common/AlbumsPage.qml 2014-08-15 01:51:59 +0000
48@@ -82,7 +82,7 @@
49 left: parent.left
50 right: parent.right
51 }
52- height: units.gu(10)
53+ height: units.gu(11)
54 clip: true
55 UbuntuShape{
56 anchors {
57@@ -117,7 +117,7 @@
58 left: parent.left
59 leftMargin: units.gu(1)
60 bottom: parent.bottom
61- bottomMargin: units.gu(5)
62+ bottomMargin: units.gu(4.5)
63 right: parent.right
64 rightMargin: units.gu(1)
65 }

Subscribers

People subscribed via source and target branches

to status/vote changes: