Merge lp:~vthompson/mediascanner2/add-case-insensitive-sorting into lp:mediascanner2
Status: | Needs review |
---|---|
Proposed branch: | lp:~vthompson/mediascanner2/add-case-insensitive-sorting |
Merge into: | lp:mediascanner2 |
Diff against target: |
70 lines (+8/-3) 1 file modified
src/mediascanner/MediaStore.cc (+8/-3) |
To merge this branch: | bzr merge lp:~vthompson/mediascanner2/add-case-insensitive-sorting |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
James Henstridge | Needs Fixing | ||
unity-api-1-bot | continuous-integration | Approve | |
Review via email: mp+241230@code.launchpad.net |
Commit message
Add case insensitive sorting.
Description of the change
This adds case insensitive sorting.
However, from the Music app side of things there is still another issue. Currently we use the SDK's SortFilterModel to sort the SongsModel on the Songs tab and the AlbumsModel on the Albums tab since both of these models are sorted by artist by default. Unfortunately, the SortFilterModel also has the same A-Za-z sorting issue, so we'd like to be able to drop it and instead have the model sorted by song title in the Songs tab (SongsModel) and by album name in the Albums tab (AlbumsModel). Do we need to file a bug for this, or do we just need assistance in getting the model properly sorted?
Unmerged revisions
- 289. By Victor Thompson
-
* Add case insensitive sorting
PASSED: Continuous integration, rev: /jenkins. canonical. com/unity- api-1/job/ lp-mediascanner 2-ci/18/ /jenkins. canonical. com/unity- api-1/job/ build/1716 /jenkins. canonical. com/unity- api-1/job/ build-0- fetch/1723 /jenkins. canonical. com/unity- api-1/job/ build-2- binpkg/ arch=amd64, release= xenial+ overlay/ 1498 /jenkins. canonical. com/unity- api-1/job/ build-2- binpkg/ arch=amd64, release= xenial+ overlay/ 1498/artifact/ output/ *zip*/output. zip /jenkins. canonical. com/unity- api-1/job/ build-2- binpkg/ arch=amd64, release= zesty/1498 /jenkins. canonical. com/unity- api-1/job/ build-2- binpkg/ arch=amd64, release= zesty/1498/ artifact/ output/ *zip*/output. zip /jenkins. canonical. com/unity- api-1/job/ build-2- binpkg/ arch=armhf, release= xenial+ overlay/ 1498 /jenkins. canonical. com/unity- api-1/job/ build-2- binpkg/ arch=armhf, release= xenial+ overlay/ 1498/artifact/ output/ *zip*/output. zip /jenkins. canonical. com/unity- api-1/job/ build-2- binpkg/ arch=armhf, release= zesty/1498 /jenkins. canonical. com/unity- api-1/job/ build-2- binpkg/ arch=armhf, release= zesty/1498/ artifact/ output/ *zip*/output. zip /jenkins. canonical. com/unity- api-1/job/ build-2- binpkg/ arch=i386, release= xenial+ overlay/ 1498 /jenkins. canonical. com/unity- api-1/job/ build-2- binpkg/ arch=i386, release= xenial+ overlay/ 1498/artifact/ output/ *zip*/output. zip /jenkins. canonical. com/unity- api-1/job/ build-2- binpkg/ arch=i386, release= zesty/1498 /jenkins. canonical. com/unity- api-1/job/ build-2- binpkg/ arch=i386, release= zesty/1498/ artifact/ output/ *zip*/output. zip
https:/
Executed test runs:
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
Click here to trigger a rebuild: /jenkins. canonical. com/unity- api-1/job/ lp-mediascanner 2-ci/18/ rebuild
https:/