Merge lp:~vthompson/dropping-letters/restart-game-play into lp:dropping-letters

Proposed by Victor Thompson
Status: Merged
Approved by: Alan Pope 🍺🐧🐱 πŸ¦„
Approved revision: 45
Merged at revision: 44
Proposed branch: lp:~vthompson/dropping-letters/restart-game-play
Merge into: lp:dropping-letters
Diff against target: 17 lines (+3/-0)
1 file modified
dropping-letters.qml (+3/-0)
To merge this branch: bzr merge lp:~vthompson/dropping-letters/restart-game-play
Reviewer Review Type Date Requested Status
Alan Pope 🍺🐧🐱 πŸ¦„ (community) Approve
Riccardo Padovani (community) Approve
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Review via email: mp+200467@code.launchpad.net

Commit message

Allow the game to restart after reaching the top of the board

Description of the change

Allow the game to restart after reaching the top of the board

To post a comment you must log in.
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
Victor Thompson (vthompson) wrote :

Could I get this reviewed?

Revision history for this message
Riccardo Padovani (rpadovani) wrote :

After I click on 'New game' the game stars as expected, but the toolbar is still visible.
I think is better if toolbar is hiddend when the game starts

review: Needs Fixing
45. By Victor Thompson

Hide toolbar on game reset.

Revision history for this message
Victor Thompson (vthompson) wrote :

Agreed.

Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
Riccardo Padovani (rpadovani) wrote :

Thanks, now looks perfect!

review: Approve
Revision history for this message
Alan Pope 🍺🐧🐱 πŸ¦„ (popey) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'dropping-letters.qml'
2--- dropping-letters.qml 2013-10-15 11:36:27 +0000
3+++ dropping-letters.qml 2014-01-26 21:03:24 +0000
4@@ -23,10 +23,13 @@
5 accum.text = "";
6 droptimer.tickCount = 0;
7 flipable.flipped = true;
8+ droptimer.start();
9+ toolbar.opened = false;
10 }
11
12 Page {
13 tools: ToolbarItems {
14+ id: toolbar
15 ToolbarButton {
16 text: i18n.tr("Sound")
17 iconSource: (volume.audible ? "audio-volume-high-symbolic.svg" : "audio-volume-muted-symbolic.svg")

Subscribers

People subscribed via source and target branches