Merge lp:~vthompson/dropping-letters/fix-1366586-dropping-letters into lp:dropping-letters

Proposed by Victor Thompson on 2014-09-12
Status: Merged
Approved by: Alan Pope 🍺🐧🐱 πŸ¦„ on 2014-09-13
Approved revision: 60
Merged at revision: 61
Proposed branch: lp:~vthompson/dropping-letters/fix-1366586-dropping-letters
Merge into: lp:dropping-letters
Diff against target: 35 lines (+4/-0)
1 file modified
dropping-letters.qml (+4/-0)
To merge this branch: bzr merge lp:~vthompson/dropping-letters/fix-1366586-dropping-letters
Reviewer Review Type Date Requested Status
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve on 2014-09-13
Nekhelesh Ramananthan (community) Approve on 2014-09-13
Alan Pope 🍺🐧🐱 πŸ¦„ 2014-09-12 Approve on 2014-09-13
Review via email: mp+234559@code.launchpad.net

Commit message

Categorize Audio type

Description of the change

Dropping letters does not currently play audio (see lp:1368998) but once that is fixed, the audio category of the sound effects will need to be set.

To post a comment you must log in.

Tests pass fine on desktop here...

alan@deep-thought:/tmp/fix-1366586-dropping-letters/tests/autopilot$ autopilot run dropping_letters_app
Loading tests from: /tmp/fix-1366586-dropping-letters/tests/autopilot

Tests running...

Ran 3 tests in 16.515s
OK

review: Approve

Not quite sure what's going on here..

The following packages have unmet dependencies:
 dropping-letters : Depends: qtdeclarative5-hud1.0 but it is not installable
E: Unable to correct problems, you have held broken packages.

Later..

could not import package dropping_letters_app: No module named 'dropping_letters_app'

Nekhelesh Ramananthan (nik90) wrote :

lgtm!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'dropping-letters.qml'
2--- dropping-letters.qml 2014-05-07 01:12:05 +0000
3+++ dropping-letters.qml 2014-09-12 23:46:11 +0000
4@@ -316,6 +316,7 @@
5 source: "407__tictacshutup__click-1-off-click.ogg"
6 autoLoad: volume.supportsMedia
7 muted: !volume.audible
8+ audioRole: MediaPlayer.alert
9 }
10
11 Audio {
12@@ -323,6 +324,7 @@
13 source: "80921__justinbw__buttonchime02up.ogg"
14 autoLoad: volume.supportsMedia
15 muted: !volume.audible
16+ audioRole: MediaPlayer.alert
17 }
18
19 Audio {
20@@ -330,6 +332,7 @@
21 source: "106727__kantouth__cartoon-bing-low.ogg"
22 autoLoad: volume.supportsMedia
23 muted: !volume.audible
24+ audioRole: MediaPlayer.alert
25 }
26
27 Audio {
28@@ -340,6 +343,7 @@
29 flipable.flipped = false
30 }
31 muted: !volume.audible
32+ audioRole: MediaPlayer.alert
33 }
34
35 Rectangle {

Subscribers

People subscribed via source and target branches