Merge lp:~vthompson/camera-app/add-infographic-to-translations into lp:camera-app

Proposed by Victor Thompson
Status: Rejected
Rejected by: Florian Boucault
Proposed branch: lp:~vthompson/camera-app/add-infographic-to-translations
Merge into: lp:camera-app
Diff against target: 25 lines (+4/-4)
1 file modified
camera-app.qml (+4/-4)
To merge this branch: bzr merge lp:~vthompson/camera-app/add-infographic-to-translations
Reviewer Review Type Date Requested Status
Ubuntu Phablet Team Pending
Review via email: mp+199285@code.launchpad.net

Commit message

Add the infographic to translations

Description of the change

A Google+ post [1] prompted the idea that the infographic text should be translatable (thanks ~daker).

[1] https://plus.google.com/u/0/101694416703170881163/posts/XPeQspoG2g6

To post a comment you must log in.
237. By Victor Thompson

Simplify translatable string in infographic

Unmerged revisions

237. By Victor Thompson

Simplify translatable string in infographic

236. By Victor Thompson

Add the infographic to translations

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'camera-app.qml'
2--- camera-app.qml 2013-10-11 00:36:09 +0000
3+++ camera-app.qml 2013-12-20 16:39:09 +0000
4@@ -345,8 +345,8 @@
5 Metric {
6 id: metricPhotos
7 name: "camera-photos"
8- format: "<b>%1</b> photos taken today"
9- emptyFormat: "No photos taken today"
10+ format: "<b>%1</b> " + i18n.tr("photos taken today")
11+ emptyFormat: i18n.tr("No photos taken today")
12 domain: "camera-app"
13 minimum: 0.0
14 }
15@@ -354,8 +354,8 @@
16 Metric {
17 id: metricVideos
18 name: "camera-videos"
19- format: "<b>%1</b> videos recorded today"
20- emptyFormat: "No videos recorded today"
21+ format: "<b>%1</b> " + i18n.tr("videos recorded today")
22+ emptyFormat: i18n.tr("No videos recorded today")
23 domain: "camera-app"
24 minimum: 0.0
25 }

Subscribers

People subscribed via source and target branches