YahooNews WebApp

Merge lp:~vrruiz/unity-webapps-yahoonews/const-to-var into lp:unity-webapps-yahoonews

  1. const-to-var
  2. Merge into trunk
Proposed by Víctor R. Ruiz
Status: Needs review
Proposed branch: lp:~vrruiz/unity-webapps-yahoonews/const-to-var
Merge into: lp:unity-webapps-yahoonews
Diff against target: 11 lines (+1/-1)
1 file modified
YahooNews.user.js (+1/-1)
To merge this branch: bzr merge lp:~vrruiz/unity-webapps-yahoonews/const-to-var
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Approve
Alexandre Abreu Pending
Review via email: mp+168756@code.launchpad.net

Commit message

Fix 'const' error (style_checker).

Description of the change

Fix 'const' error (style_checker).

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:46
http://jenkins.qa.ubuntu.com/job/unity-webapps-yahoonews-ci/1/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-webapps-yahoonews-saucy-amd64-ci/1
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-webapps-yahoonews-saucy-armhf-ci/1

Click here to trigger a rebuild:
http://s-jenkins:8080/job/unity-webapps-yahoonews-ci/1/rebuild

review: Approve (continuous-integration)
Reply

Unmerged revisions

46. By Víctor R. Ruiz

Fix 'const' complain for style_checker

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'YahooNews.user.js'
2--- YahooNews.user.js 2013-05-03 06:10:42 +0000
3+++ YahooNews.user.js 2013-06-11 17:47:53 +0000
4@@ -6,7 +6,7 @@
5 // ==/UserScript==
6
7 // This placeholder gets munged with real data at build time.
8-const WebappsGettextDict = JSON.parse(unescape(
9+var WebappsGettextDict = JSON.parse(unescape(
10 "%7B%22GETTEXT%22%3A%22PLACEHOLDER%22%7D"
11 ));
12

Subscribers

People subscribed via source and target branches

to all changes: