Merge lp:~vrruiz/unity-webapps-linkedin/const-to-var into lp:unity-webapps-linkedin

Proposed by Víctor R. Ruiz
Status: Rejected
Rejected by: Robert Bruce Park
Proposed branch: lp:~vrruiz/unity-webapps-linkedin/const-to-var
Merge into: lp:unity-webapps-linkedin
Diff against target: 11 lines (+1/-1)
1 file modified
LinkedIn.user.js (+1/-1)
To merge this branch: bzr merge lp:~vrruiz/unity-webapps-linkedin/const-to-var
Reviewer Review Type Date Requested Status
Robert Bruce Park (community) Disapprove
PS Jenkins bot (community) continuous-integration Needs Fixing
Alexandre Abreu Pending
Review via email: mp+168767@code.launchpad.net

Commit message

Fix 'const' error (style_checker).

Description of the change

Fix 'const' error (style_checker).

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Robert Bruce Park (robru) wrote :

What's the deal with selfTest()? Why is it not defined for linkedin? Other apps seem to define their own...

Revision history for this message
Robert Bruce Park (robru) wrote :
review: Disapprove

Unmerged revisions

47. By Víctor R. Ruiz

Fix 'const' complain for style_checker

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'LinkedIn.user.js'
2--- LinkedIn.user.js 2013-06-07 15:33:16 +0000
3+++ LinkedIn.user.js 2013-06-11 17:50:54 +0000
4@@ -5,7 +5,7 @@
5 // ==/UserScript==
6
7 // This placeholder gets munged with real data at build time.
8-const WebappsGettextDict = JSON.parse(unescape(
9+var WebappsGettextDict = JSON.parse(unescape(
10 "%7B%22GETTEXT%22%3A%22PLACEHOLDER%22%7D"
11 ));
12

Subscribers

People subscribed via source and target branches

to all changes: