LastFM-Radio WebApp

Merge lp:~vrruiz/unity-webapps-lastfm-radio/const-to-var into lp:unity-webapps-lastfm-radio

  1. const-to-var
  2. Merge into trunk
Proposed by Víctor R. Ruiz
Status: Rejected
Rejected by: Robert Bruce Park
Proposed branch: lp:~vrruiz/unity-webapps-lastfm-radio/const-to-var
Merge into: lp:unity-webapps-lastfm-radio
Diff against target: 11 lines (+1/-1)
1 file modified
lastfm-radio.user.js (+1/-1)
To merge this branch: bzr merge lp:~vrruiz/unity-webapps-lastfm-radio/const-to-var
Reviewer Review Type Date Requested Status
Robert Bruce Park (community) Disapprove
PS Jenkins bot (community) continuous-integration Needs Fixing
Alexandre Abreu Pending
Review via email: mp+168770@code.launchpad.net

Commit message

Fix 'const' error (style_checker).

Description of the change

Fix 'const' error (style_checker).

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:31
http://jenkins.qa.ubuntu.com/job/unity-webapps-lastfm-radio-ci/1/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-webapps-lastfm-radio-saucy-amd64-ci/1/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-webapps-lastfm-radio-saucy-armhf-ci/1/console

Click here to trigger a rebuild:
http://s-jenkins:8080/job/unity-webapps-lastfm-radio-ci/1/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Robert Bruce Park (robru) wrote :

My branch at https://code.launchpad.net/~robru/unity-webapps-lastfm-radio/manifest/+merge/169041 includes and supercedes this one.

review: Disapprove

Unmerged revisions

31. By Víctor R. Ruiz

Fix 'const' complain for style_checker

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'lastfm-radio.user.js'
2--- lastfm-radio.user.js 2013-05-03 23:12:05 +0000
3+++ lastfm-radio.user.js 2013-06-11 17:52:39 +0000
4@@ -11,7 +11,7 @@
5 // ==/UserScript==
6
7 // This placeholder gets munged with real data at build time.
8-const WebappsGettextDict = JSON.parse(unescape(
9+var WebappsGettextDict = JSON.parse(unescape(
10 "%7B%22GETTEXT%22%3A%22PLACEHOLDER%22%7D"
11 ));
12

Subscribers

People subscribed via source and target branches

to all changes: