Merge lp:~vrruiz/gallery-app/open-with-content-hub into lp:gallery-app

[Víctor R. Ruiz]

Test to check that the gallery is opened by the content hub.

Test to check that the gallery is opened by the content hub.

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:920
http://jenkins.qa.ubuntu.com/job/gallery-app-ci/674/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/gallery-app-trusty-amd64-ci/99
    SUCCESS: http://jenkins.qa.ubuntu.com/job/gallery-app-trusty-armhf-ci/100
        deb: http://jenkins.qa.ubuntu.com/job/gallery-app-trusty-armhf-ci/100/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/gallery-app-trusty-i386-ci/99
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty/3545
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty-touch/3159/console
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-trusty/3120
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/3549
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/3549/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-armhf/3161
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-armhf/3161/artifact/work/output/*zip*/output.zip
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-mako/5546/console
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/4323

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/gallery-app-ci/674/rebuild

review: Needs Fixing (continuous-integration)

[Javier Collado (javier.collado)]

Is there a way to check that the proxy object is the one that we expect?

If not, then I think I'd just remove the variable from the test, that is,
replace this:
gallery = helpers.open_gallery_with_content_hub()

with this:
helpers.open_gallery_with_content_hub()

[Leo Arias (elopio)]

We could do something like self.assertTrue(gallery.main_view.visible)
For that, you would need to apss the emulator base class parameter to get_proxy_object_for_existing_process.

We have a problem here because you are selecting the process manager with the bamf backend, that's not available on the phone. Will it work if you don't pass any preferred_backend so it chooses the right one?

[Leo Arias (elopio)]

review: Needs Information

Unmerged revisions

920. By Víctor R. Ruiz on 2014-02-26

Autopilot test to open the gallery app with the content hub

919. By Víctor R. Ruiz on 2014-02-26

Autopilot test to open the gallery app with the content hub

=== modified file 'debian/control'
--- debian/control	2014-01-14 08:01:56 +0000
+++ debian/control	2014-02-26 17:37:30 +0000
@@ -52,6 +52,9 @@
          libqt5test5,
          ubuntu-ui-toolkit-autopilot,
          unity8-autopilot,
+         python-psutil,
+         python-dbus,
+         content-hub,
 Description: Autopilot tests for the photo gallery for Ubuntu
  gallery-app is a photo gallery for the Ubuntu platform. This package contains
  autopilot tests for it.

=== added file 'tests/autopilot/gallery_app/helpers.py'
--- tests/autopilot/gallery_app/helpers.py	1970-01-01 00:00:00 +0000
+++ tests/autopilot/gallery_app/helpers.py	2014-02-26 17:37:30 +0000
@@ -0,0 +1,51 @@
+# -*- Mode: Python; coding: utf-8; indent-tabs-mode: nil; tab-width: 4 -*-
+# Copyright (C) 2014 Canonical  
+#  
+# This program is free software: you can redistribute it and/or modify  
+# it under the terms of the GNU General Public License as published by  
+# the Free Software Foundation, either version 3 of the License, or  
+# (at your option) any later version.  
+#  
+# This program is distributed in the hope that it will be useful,  
+# but WITHOUT ANY WARRANTY; without even the implied warranty of  
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the  
+# GNU General Public License for more details.  
+#  
+# You should have received a copy of the GNU General Public License  
+# along with this program. If not, see <http://www.gnu.org/licenses/>.  
+
+import dbus
+from time import sleep
+import psutil
+
+from autopilot import introspection
+from autopilot.process import ProcessManager
+
+def open_gallery_with_content_hub():
+    """ Opens the gallery-app with the content-hub """
+    type_id = 'pictures'
+    app_id = ''
+    desktop_file = '/usr/share/applications/gallery-app.desktop'
+
+    process_manager = ProcessManager.create(preferred_backend='BAMF')
+
+    # Get session dbus
+    session_dbus = dbus.SessionBus()
+    proxy = session_dbus.get_object('com.ubuntu.content.dbus.Service', '/')
+
+    # Call content-hub to request a picture
+    peer_id = proxy.DefaultPeerForType('pictures') # Returns 'gallery-app'
+    object_path = proxy.CreateImportForTypeFromPeer(type_id, peer_id, app_id)
+    proxy_transfer = session_dbus.get_object('com.ubuntu.content.dbus.Service', object_path)
+    selection_type = proxy_transfer.SelectionType()
+    store = proxy_transfer.Store()
+    proxy_transfer.Start() # This opens the gallery app
+
+    # Wait until the application is open
+    process_manager.wait_until_application_is_running(desktop_file, 10)
+
+    # Get and return app proxy
+    gallery_process = next(p for p in psutil.get_process_list()
+        if p.name == 'gallery-app')
+    return introspection.get_proxy_object_for_existing_process(pid=gallery_process.pid)
+

=== added file 'tests/autopilot/gallery_app/tests/test_open_gallery.py'
--- tests/autopilot/gallery_app/tests/test_open_gallery.py	1970-01-01 00:00:00 +0000
+++ tests/autopilot/gallery_app/tests/test_open_gallery.py	2014-02-26 17:37:30 +0000
@@ -0,0 +1,27 @@
+# -*- Mode: Python; coding: utf-8; indent-tabs-mode: nil; tab-width: 4 -*- 
+# Copyright (C) 2014 Canonical  
+#  
+# This program is free software: you can redistribute it and/or modify  
+# it under the terms of the GNU General Public License as published by  
+# the Free Software Foundation, either version 3 of the License, or  
+# (at your option) any later version.  
+#  
+# This program is distributed in the hope that it will be useful,  
+# but WITHOUT ANY WARRANTY; without even the implied warranty of  
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the  
+# GNU General Public License for more details.  
+#  
+# You should have received a copy of the GNU General Public License  
+# along with this program. If not, see <http://www.gnu.org/licenses/>.  
+#
+
+import testtools
+
+from gallery_app import helpers
+
+class OpenGalleryTestCase(testtools.TestCase):
+    """Test that opens the gallery"""
+
+    def test_open_gallery_with_content_hub(self):
+        """Uses the content hub to open the gallery"""
+        gallery = helpers.open_gallery_with_content_hub()