Code review comment for lp:~vrruiz/cordova-ubuntu-tests/ap-better-reporting

Revision history for this message
Robert Bruce Park (robru) wrote :

What is the purpose of get_www_dir_path? Unlike get_{cordova_container,persistent}_path, it returns the same value regardless of what happens in the if statement, making it useless. Do you intend to do something about the www dir not existing? It should be guaranteed to exist due to the dependencies of the deb package. Please drop that function and reference self.WWW_DIR_PATH wherever you would call self.get_www_dir_path() from.

review: Needs Fixing

« Back to merge proposal