Merge ~vpa1977/ubuntu/+source/ssvnc:java21-ftbfs into ubuntu/+source/ssvnc:ubuntu/devel

Proposed by Vladimir Petko
Status: Merged
Merge reported by: Vladimir Petko
Merged at revision: 33d355164db190ecaea26ff8146ef713042809b2
Proposed branch: ~vpa1977/ubuntu/+source/ssvnc:java21-ftbfs
Merge into: ubuntu/+source/ssvnc:ubuntu/devel
Diff against target: 65 lines (+15/-5)
3 files modified
debian/changelog (+9/-0)
debian/control (+2/-1)
debian/rules (+4/-4)
Reviewer Review Type Date Requested Status
Canonical Foundations Team Pending
Ubuntu Sponsors Pending
git-ubuntu import Pending
Review via email: mp+460542@code.launchpad.net

Description of the change

This MP resolves Java 21 ftbfs and the rebuild issue since it blocks package rebuilds.

PPA: ppa:vpa1977/gettext [1]

Changes:
 - Use java_compat_level variable provided by java-common to adjust -source/-target level to the minimum required by the default Java
 - Force deletion of vnc_unixsrc/*/Makefile

Testing:
 - rebuild in default Java 21 ppa[2]
 - piuparts test [3]
 - rebuild the package after the successfull build[4]

[1] https://launchpad.net/~vpa1977/+archive/ubuntu/gettext
[2] https://launchpad.net/~vpa1977/+archive/ubuntu/gettext-21/+sourcepub/15788007/+listing-archive-extra
[3] https://bugs.launchpad.net/ubuntu/+source/ssvnc/+bug/2053195/comments/1
[4] https://bugs.launchpad.net/ubuntu/+source/ssvnc/+bug/2053196/comments/1

To post a comment you must log in.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/debian/changelog b/debian/changelog
2index d2866a4..a9803e7 100644
3--- a/debian/changelog
4+++ b/debian/changelog
5@@ -1,3 +1,12 @@
6+ssvnc (1.0.29-6ubuntu1) noble; urgency=medium
7+
8+ * d/rules: use java_compat_level variable provided by java-common
9+ to adjust -source/-target level to the minimum required by
10+ the default Java (LP: #2053195).
11+ * d/rules: force deletion of vnc_unixsrc/*/Makefile (LP: #2053196).
12+
13+ -- Vladimir Petko <vladimir.petko@canonical.com> Thu, 15 Feb 2024 10:55:51 +1300
14+
15 ssvnc (1.0.29-6) unstable; urgency=low
16
17 * no-mkmf.patch: Replace Imake-generated Makefiles with simple ones in
18diff --git a/debian/control b/debian/control
19index 399b1a5..c6304a1 100644
20--- a/debian/control
21+++ b/debian/control
22@@ -1,7 +1,8 @@
23 Source: ssvnc
24 Section: net
25 Priority: optional
26-Maintainer: Magnus Holmgren <holmgren@debian.org>
27+Maintainer: Ubuntu Developers <ubuntu-devel-discuss@lists.ubuntu.com>
28+XSBC-Original-Maintainer: Magnus Holmgren <holmgren@debian.org>
29 Build-Depends: dpkg-dev (>= 1.15.7), debhelper (>= 10), xutils-dev, libxaw7-dev,
30 libxmu-dev, libxext-dev, libxt-dev, libsm-dev, libice-dev,
31 libjpeg-dev, zlib1g-dev | libz-dev,
32diff --git a/debian/rules b/debian/rules
33index e786be2..9228a6d 100755
34--- a/debian/rules
35+++ b/debian/rules
36@@ -8,7 +8,7 @@
37
38 # Uncomment this to turn on verbose mode.
39 #export DH_VERBOSE=1
40-
41+include /usr/share/java/java_defaults.mk
42 DESTDIR=$(CURDIR)/debian/ssvnc
43
44 export CPPFLAGS := $(shell dpkg-buildflags --get CPPFLAGS)
45@@ -27,7 +27,7 @@ build-arch: build-stamp
46 build-stamp: configure-stamp
47 dh_testdir
48
49- $(MAKE) all JC_ARGS="-source 1.7 -target 1.7"
50+ $(MAKE) all JC_ARGS="-source $(java_compat_level) -target $(java_compat_level)"
51
52 touch $@
53
54@@ -39,9 +39,9 @@ clean: configure-stamp
55 rm -f build-stamp configure-stamp
56
57 $(MAKE) clean
58- rm vnc_unixsrc/*/Makefile
59+ rm -f vnc_unixsrc/*/Makefile
60
61- dh_clean
62+ dh_clean
63
64 install: build
65 dh_testdir

Subscribers

People subscribed via source and target branches