Merge ~vpa1977/ubuntu/+source/qpid-proton-j-extensions:ubuntu/devel into ubuntu/+source/qpid-proton-j-extensions:ubuntu/devel

Proposed by Vladimir Petko
Status: Merged
Merge reported by: Vladimir Petko
Merged at revision: 23d4a3f7d242e0109199173af2fc855d631590f9
Proposed branch: ~vpa1977/ubuntu/+source/qpid-proton-j-extensions:ubuntu/devel
Merge into: ubuntu/+source/qpid-proton-j-extensions:ubuntu/devel
Diff against target: 86 lines (+45/-1)
5 files modified
debian/changelog (+8/-0)
debian/control (+2/-1)
debian/patches/javac-source-target.patch (+30/-0)
debian/patches/series (+1/-0)
debian/rules (+4/-0)
Reviewer Review Type Date Requested Status
Canonical Foundations Team Pending
git-ubuntu import Pending
Review via email: mp+460731@code.launchpad.net

Description of the change

This MP resolves Java 21 ftbfs.

PPA: ppa:vpa1977/gettext [1]

Changes:
 - Use java_compat_level variable provided by java-common to adjust -source/-target level to the minimum required by the default Java

Testing:
 - rebuild in default Java 21 ppa[2]
 - piuparts test [3]

[1] https://launchpad.net/~vpa1977/+archive/ubuntu/gettext
[2] https://launchpad.net/~vpa1977/+archive/ubuntu/gettext-21/+sourcepub/15798611/+listing-archive-extra
[3] https://bugs.launchpad.net/ubuntu/+source/qpid-proton-j-extensions/+bug/2054236/comments/1

To post a comment you must log in.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/debian/changelog b/debian/changelog
2index 32b04f6..d64059d 100644
3--- a/debian/changelog
4+++ b/debian/changelog
5@@ -1,3 +1,11 @@
6+qpid-proton-j-extensions (1.2.4-1ubuntu1) noble; urgency=medium
7+
8+ [ Pushkar Kulkarni ]
9+ * Use java-common's java_compat_level for -source/-target. Disable -Xlint
10+ options warning (LP: #2054236).
11+
12+ -- Vladimir Petko <vladimir.petko@canonical.com> Mon, 19 Feb 2024 08:42:11 +1300
13+
14 qpid-proton-j-extensions (1.2.4-1) unstable; urgency=medium
15
16 * Initial release
17diff --git a/debian/control b/debian/control
18index a8259ec..1b0d9db 100644
19--- a/debian/control
20+++ b/debian/control
21@@ -1,7 +1,8 @@
22 Source: qpid-proton-j-extensions
23 Section: java
24 Priority: optional
25-Maintainer: Debian Java Maintainers <pkg-java-maintainers@lists.alioth.debian.org>
26+Maintainer: Ubuntu Developers <ubuntu-devel-discuss@lists.ubuntu.com>
27+XSBC-Original-Maintainer: Debian Java Maintainers <pkg-java-maintainers@lists.alioth.debian.org>
28 Uploaders: Joseph Nahmias <jello@debian.org>
29 Build-Depends:
30 debhelper-compat (= 13),
31diff --git a/debian/patches/javac-source-target.patch b/debian/patches/javac-source-target.patch
32new file mode 100644
33index 0000000..9756675
34--- /dev/null
35+++ b/debian/patches/javac-source-target.patch
36@@ -0,0 +1,30 @@
37+Description: use java-common's java_compat_level for -source/-target
38+ This is a Debian/Ubuntu-specific patch to replace hardcoded
39+ -source/-target level with the one provided by java-common.
40+ Disable -Xlint options warning.
41+Author: Pushkar Kulkarni <pushkar.kulkarni@canonical.com>
42+Bug-Debian: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1057533
43+Bug-Ubuntu: https://bugs.launchpad.net/debian/+source/qpid-proton-j-extensions/+bug/2054236
44+Forwarded: not-needed
45+Last-Update: 2024-02-19
46+--- a/pom.xml
47++++ b/pom.xml
48+@@ -183,6 +183,7 @@
49+ <arg>-Xlint:try</arg>
50+ <arg>-Xlint:unchecked</arg>
51+ <arg>-Xlint:varargs</arg>
52++ <arg>-Xlint:-options</arg>
53+ </compilerArgs>
54+ </configuration>
55+ </plugin>
56+@@ -357,8 +358,8 @@
57+ <jdk>[1.8,9)</jdk>
58+ </activation>
59+ <properties>
60+- <maven.compiler.source>8</maven.compiler.source>
61+- <maven.compiler.target>8</maven.compiler.target>
62++ <maven.compiler.source>${env.JAVA_SOURCE_VERSION}</maven.compiler.source>
63++ <maven.compiler.target>${env.JAVA_TARGET_VERSION}</maven.compiler.target>
64+ </properties>
65+ <build>
66+ <plugins>
67diff --git a/debian/patches/series b/debian/patches/series
68new file mode 100644
69index 0000000..0b3f39e
70--- /dev/null
71+++ b/debian/patches/series
72@@ -0,0 +1 @@
73+javac-source-target.patch
74diff --git a/debian/rules b/debian/rules
75index 2d33f6a..21a32ce 100755
76--- a/debian/rules
77+++ b/debian/rules
78@@ -1,4 +1,8 @@
79 #!/usr/bin/make -f
80
81+include /usr/share/java/java_defaults.mk
82+export JAVA_SOURCE_VERSION = $(java_compat_level)
83+export JAVA_TARGET_VERSION = $(java_compat_level)
84+
85 %:
86 dh $@

Subscribers

People subscribed via source and target branches