Merge ~vpa1977/ubuntu/+source/pgpool2:fix-autopkgtest into ubuntu/+source/pgpool2:ubuntu/devel

[Vladimir Petko]

This MR fixes autopkgtest failure for Java 21

PPA: ppa:vpa1977/plusone [1]

Changes:
 - Remove deprecated API calls

Testing:
 - autopkgtest:
 pgpool2/4.3.7-1ubuntu1~ppa1
    + ✅ pgpool2 on noble for amd64 @ 26.02.24 03:15:21 Log️ 🗒️ [2]
    + ✅ pgpool2 on noble for arm64 @ 26.02.24 03:39:35 Log️ 🗒️ [3]
    + ❌ pgpool2 on noble for armhf @ 26.02.24 03:33:37 Log️ 🗒️ [4]
      • jdbc-tests FAIL 🟥
      • installcheck PASS 🟩
    + ✅ pgpool2 on noble for ppc64el @ 26.02.24 03:26:14 Log️ 🗒️ [5]
    + ✅ pgpool2 on noble for s390x @ 26.02.24 03:19:48 Log️ 🗒️ [6]

Note: armf failure is an existing issue[7]
  - install-remove, install-upgrade-purge test [8].

[1] https://launchpad.net/~vpa1977/+archive/ubuntu/plusone/+packages
[2] https://autopkgtest.ubuntu.com/results/autopkgtest-noble-vpa1977-plusone/noble/amd64/p/pgpool2/20240226_031521_b3869@/log.gz
[3] https://autopkgtest.ubuntu.com/results/autopkgtest-noble-vpa1977-plusone/noble/arm64/p/pgpool2/20240226_033935_e8357@/log.gz
[4] https://autopkgtest.ubuntu.com/results/autopkgtest-noble-vpa1977-plusone/noble/armhf/p/pgpool2/20240226_033337_a020b@/log.gz
[5] https://autopkgtest.ubuntu.com/results/autopkgtest-noble-vpa1977-plusone/noble/ppc64el/p/pgpool2/20240226_032614_e33b4@/log.gz
[6] https://autopkgtest.ubuntu.com/results/autopkgtest-noble-vpa1977-plusone/noble/s390x/p/pgpool2/20240226_031948_4810a@/log.gz
[7] https://autopkgtest.ubuntu.com/packages/p/pgpool2/noble/armhf
[8] https://bugs.launchpad.net/ubuntu/+source/pgpool2/+bug/2054944/comments/1

[Pushkar Kulkarni (pushkarnk)]

Pushing the patch creates a stray getTestName() call which could be removed. Also, the indentation needs to be fixed. Comments inline.

review: Needs Fixing

[Vladimir Petko (vpa1977)]

> Pushing the patch creates a stray getTestName() call which could be removed.
Fixed, Thank you!!!!

> Also, the indentation needs to be fixed. Comments inline.
LP does not show inline comments ;( I have replaced tab-tab with tab-spaces

[Pushkar Kulkarni (pushkarnk)]

Thanks! LGTM.

review: Approve

[Vladimir Petko (vpa1977)]

Uploaded, thank you!

diff --git a/debian/changelog b/debian/changelog
index 0a70233..11e6702 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,11 @@
+pgpool2 (4.3.7-1ubuntu1) noble; urgency=medium
+
+  * d/p/java21-deprecation.patch: fix autopkgtest failure with
+    Java 21. Use Runtime.exec(String[]) to avoid deprecation warning
+    (LP: #2054944).
+
+ -- Vladimir Petko <[e-mail]>  Mon, 26 Feb 2024 14:41:25 +1300
+
 pgpool2 (4.3.7-1) unstable; urgency=medium
 
   * New upstream version 4.3.7.
diff --git a/debian/control b/debian/control
index d872a7e..43460ff 100644
--- a/debian/control
+++ b/debian/control
@@ -1,7 +1,8 @@
 Source: pgpool2
 Section: database
 Priority: optional
-Maintainer: Debian PostgreSQL Maintainers <[e-mail]>
+Maintainer: Ubuntu Developers <[e-mail]>
+XSBC-Original-Maintainer: Debian PostgreSQL Maintainers <[e-mail]>
 Uploaders:
  Christoph Berg <[e-mail]>,
  Marco Nenciarini <[e-mail]>,
diff --git a/debian/control.in b/debian/control.in
index d7f0a98..47b376c 100644
--- a/debian/control.in
+++ b/debian/control.in
@@ -1,7 +1,8 @@
 Source: pgpool2
 Section: database
 Priority: optional
-Maintainer: Debian PostgreSQL Maintainers <[e-mail]>
+Maintainer: Ubuntu Developers <[e-mail]>
+XSBC-Original-Maintainer: Debian PostgreSQL Maintainers <[e-mail]>
 Uploaders:
  Christoph Berg <[e-mail]>,
  Marco Nenciarini <[e-mail]>,
diff --git a/debian/patches/java21-deprecation.patch b/debian/patches/java21-deprecation.patch
new file mode 100644
index 0000000..e68239c
--- /dev/null
+++ b/debian/patches/java21-deprecation.patch
@@ -0,0 +1,48 @@
+Description: replace Runtime.exec(String) with Runtime.exec(String[])
+ Runtime.exec(String) is deprecated in Java 21.
+ The deprecation warning is output to stderr failing autopkgtests.
+Author: Vladimir Petko <[e-mail]>
+Bug: https://github.com/pgpool/pgpool2/pull/40
+Bug-Debian: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1064789
+Bug-Ubuntu: https://bugs.launchpad.net/debian/+source/pgpool2/+bug/2054944
+Last-Update: 2024-02-26
+--- a/src/test/regression/tests/005.jdbc/PgpoolTest.java
++++ b/src/test/regression/tests/005.jdbc/PgpoolTest.java
+@@ -52,11 +52,16 @@
+
+     public void check() {
+ 	try {
+-	    String command_line = "diff -u expected/" + getTestName() + " result/" +
+-		getTestName();
+ 	    Process proc;
+
+-	    proc = Runtime.getRuntime().exec(command_line);
++	    proc = Runtime.getRuntime().exec(new String[]{
++	    	"diff",
++	    	"-u",
++	    	"expected/",
++	    	getTestName(),
++	    	"result/",
++	    	getTestName()
++	    });
+ 	    proc.waitFor();
+ 	    System.out.print(getTestName() + ": ");
+ 	    if (proc.exitValue() == 0)
+--- a/src/test/regression/tests/005.jdbc/RunTest.java
++++ b/src/test/regression/tests/005.jdbc/RunTest.java
+@@ -23,10 +23,11 @@
+ 	    String dbname = prop.getProperty("pgpooltest.dbname");
+
+ 	    // setup database
+-	    String command_line = "psql -f prepare.sql";
+-	    command_line = command_line + " -h " + host + " -p " + port +
+-		" -U " + user + " " + dbname;
+-	    Process proc = Runtime.getRuntime().exec(command_line);
++	    Process proc = Runtime.getRuntime().exec(new String[]{
++	    	"psql", "-f", "prepare.sql",
++	    	"-h", host, "-p ", port,
++	    	"-U", user, dbname
++	    });
+ 	    proc.waitFor();
+
+ 	    StringTokenizer tokenizer = new StringTokenizer(tests, " ");
diff --git a/debian/patches/series b/debian/patches/series
index c0c8554..490cddb 100644
--- a/debian/patches/series
+++ b/debian/patches/series
@@ -1,2 +1,3 @@
 pgpool2-debian-config.patch
 sbin-paths
+java21-deprecation.patch