Merge ~vpa1977/ubuntu/+source/openjdk-17:lp2011653-drop-patches into ubuntu/+source/openjdk-17:ubuntu/devel

Proposed by Vladimir Petko
Status: Merged
Merged at revision: a4abf2f689bd1b507113b5c49dffd820fdb9a050
Proposed branch: ~vpa1977/ubuntu/+source/openjdk-17:lp2011653-drop-patches
Merge into: ubuntu/+source/openjdk-17:ubuntu/devel
Diff against target: 93 lines (+10/-14)
4 files modified
debian/changelog (+9/-0)
debian/patches/hotspot-disable-exec-shield-workaround.diff (+1/-1)
debian/patches/series (+0/-2)
dev/null (+0/-11)
Reviewer Review Type Date Requested Status
Steve Langasek (community) Approve
git-ubuntu import Pending
Review via email: mp+439093@code.launchpad.net

Description of the change

Please do not merge, this merge proposal is a part of a series [1][2][3].

Summary of changes:
  * d/p: drop obsolete patches (LP: #2011653).
    - workaround_expand_exec_shield_cs_limit.diff: obsoleted by
      hotspot-disable-exec-shield-workaround.diff.
    - generated-headers.patch: include is already added by openjdk makefile.

PPA: ppa:vpa1977/openjdk-drop-patches [4]

Testing:
 No functional changes in this MP:
       - workaround_expand_exec_shield_cs_limit.diff is obsoleted by another patch applied later in the series
       - generated-headers.patch/parallel-build-fix.patch provide an include directory. If something relies on files in those directories, compilation will be broken.

  Compilation must succeed [5]. Draft version of the package with some extra unneeded changes built successfully [6].

[1] https://code.launchpad.net/~vpa1977/ubuntu/+source/openjdk-17/+git/openjdk-17/+merge/439093
[2] https://code.launchpad.net/~vpa1977/ubuntu/+source/openjdk-17/+git/openjdk-17/+merge/439105
[3] https://code.launchpad.net/~vpa1977/ubuntu/+source/openjdk-17/+git/openjdk-17/+merge/439104
[4] https://launchpad.net/~vpa1977/+archive/ubuntu/openjdk-drop-patches
[5] https://launchpad.net/~vpa1977/+archive/ubuntu/openjdk-drop-patches/+sourcepub/14557191/+listing-archive-extra
[6] https://launchpad.net/~vpa1977/+archive/ubuntu/openjdk-drop-patches/+sourcepub/14556137/+listing-archive-extra

To post a comment you must log in.
Revision history for this message
Steve Langasek (vorlon) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/debian/changelog b/debian/changelog
2index 02ee7f6..aa26da9 100644
3--- a/debian/changelog
4+++ b/debian/changelog
5@@ -1,3 +1,12 @@
6+openjdk-17 (17.0.6+10-1ubuntu2) UNRELEASED; urgency=medium
7+
8+ * d/p: drop obsolete patches (LP: #2011653).
9+ - workaround_expand_exec_shield_cs_limit.diff: obsoleted by
10+ hotspot-disable-exec-shield-workaround.diff.
11+ - generated-headers.patch: include is already added by openjdk makefile.
12+
13+ -- Vladimir Petko <vladimir.petko@canonical.com> Thu, 16 Mar 2023 15:04:36 +1300
14+
15 openjdk-17 (17.0.6+10-1ubuntu1) lunar; urgency=medium
16
17 * debian/JB-jre-headless.postinst.in: trigger ca-certificates-java after jre
18diff --git a/debian/patches/generated-headers.patch b/debian/patches/generated-headers.patch
19deleted file mode 100644
20index 9c5a2d3..0000000
21--- a/debian/patches/generated-headers.patch
22+++ /dev/null
23@@ -1,20 +0,0 @@
24---- a/make/modules/java.desktop/lib/Awt2dLibraries.gmk
25-+++ b/make/modules/java.desktop/lib/Awt2dLibraries.gmk
26-@@ -290,7 +290,7 @@
27- INCLUDE_FILES := $(BUILD_LIBLCMS_INCLUDE_FILES), \
28- OPTIMIZATION := HIGHEST, \
29- CFLAGS := $(CFLAGS_JDKLIB) \
30-- $(LCMS_CFLAGS), \
31-+ $(LCMS_CFLAGS) -I$(SUPPORT_OUTPUTDIR)/headers/java.desktop, \
32- CFLAGS_windows := -DCMS_IS_WINDOWS_, \
33- EXTRA_HEADER_DIRS := \
34- common/awt/debug \
35-@@ -338,7 +338,7 @@
36- NAME := javajpeg, \
37- INCLUDE_FILES := $(BUILD_LIBJAVAJPEG_INCLUDE_FILES), \
38- OPTIMIZATION := HIGHEST, \
39-- CFLAGS := $(CFLAGS_JDKLIB), \
40-+ CFLAGS := $(CFLAGS_JDKLIB) -I$(SUPPORT_OUTPUTDIR)/headers/java.desktop, \
41- HEADERS_FROM_SRC := $(LIBJPEG_HEADERS_FROM_SRC), \
42- DISABLED_WARNINGS_gcc := clobbered implicit-fallthrough shift-negative-value array-bounds, \
43- LDFLAGS := $(LDFLAGS_JDKLIB) \
44diff --git a/debian/patches/hotspot-disable-exec-shield-workaround.diff b/debian/patches/hotspot-disable-exec-shield-workaround.diff
45index 924a182..0891ed9 100644
46--- a/debian/patches/hotspot-disable-exec-shield-workaround.diff
47+++ b/debian/patches/hotspot-disable-exec-shield-workaround.diff
48@@ -4,7 +4,7 @@
49 * updates (JDK-8023956).
50 */
51 void os::workaround_expand_exec_shield_cs_limit() {
52--#if defined(IA32) && !defined(ZERO)
53+-#if defined(IA32)
54 +#if 0
55 assert(Linux::initial_thread_stack_bottom() != NULL, "sanity");
56 size_t page_size = os::vm_page_size();
57diff --git a/debian/patches/series b/debian/patches/series
58index bbfe8be..c918e98 100644
59--- a/debian/patches/series
60+++ b/debian/patches/series
61@@ -4,7 +4,6 @@ icc_loading_with_symlink.diff
62 icedtea-override-redirect-compiz.diff
63 libpcsclite-dlopen.diff
64 default-jvm-cfg.diff
65-workaround_expand_exec_shield_cs_limit.diff
66 adlc-parser.diff
67 multiple-pkcs11-library-init.diff
68 s390x-opt.diff
69@@ -17,7 +16,6 @@ zero-x32.diff
70 hotspot-disable-exec-shield-workaround.diff
71 atk-wrapper-security.diff
72 dnd-files.diff
73-generated-headers.patch
74 m68k-support.diff
75 reproducible-properties-timestamp.diff
76 # reproducible-javadoc-timestamp.diff
77diff --git a/debian/patches/workaround_expand_exec_shield_cs_limit.diff b/debian/patches/workaround_expand_exec_shield_cs_limit.diff
78deleted file mode 100644
79index bad6c03..0000000
80--- a/debian/patches/workaround_expand_exec_shield_cs_limit.diff
81+++ /dev/null
82@@ -1,11 +0,0 @@
83---- a/src/hotspot/os_cpu/linux_x86/os_linux_x86.cpp
84-+++ b/src/hotspot/os_cpu/linux_x86/os_linux_x86.cpp
85-@@ -651,7 +651,7 @@
86- * updates (JDK-8023956).
87- */
88- void os::workaround_expand_exec_shield_cs_limit() {
89--#if defined(IA32)
90-+#if defined(IA32) && !defined(ZERO)
91- assert(Linux::initial_thread_stack_bottom() != NULL, "sanity");
92- size_t page_size = os::vm_page_size();
93-

Subscribers

People subscribed via source and target branches