Merge ~vpa1977/ubuntu/+source/ncrack:ubuntu/devel into ubuntu/+source/ncrack:ubuntu/devel

[Vladimir Petko]

Changes:
 - add missing headers to the configure script

PPA: ppa:vpa1977/october-21[1]

Testing:
 - build succeeds[1]
 - piuparts test (amd64)
0m45.2s INFO: PASS: All tests.
0m45.2s INFO: piuparts run ends.
 - package installs on armhf
 - smoke test on armhf
---
  ncrack -v -T5 https://192.168.0.1

Starting Ncrack 0.7 ( http://ncrack.org ) at 2024-04-14 20:58 UTC

https://192.168.0.1:443 finished.

Ncrack done: 1 service scanned in 9.00 seconds.
Probes sent: 1 | timed-out: 1 | prematurely-closed: 0

Ncrack finished.
---

[1] https://launchpad.net/~vpa1977/+archive/ubuntu/october-21/+sourcepub/15931126/+listing-archive-extra

diff --git a/debian/changelog b/debian/changelog
index a2128fe..99d5a04 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,11 @@
+ncrack (0.7+debian-5ubuntu1) noble; urgency=medium
+
+  * debian/patches/implicit-declaration-in-configure.patch: add missing
+    headers to workaround -Werror=implicit-function-declaration (Closes:
+    #1065799, LP: #2060908).
+
+ -- Vladimir Petko <[e-mail]>  Fri, 12 Apr 2024 19:45:45 +1200
+
 ncrack (0.7+debian-5build2) noble; urgency=medium
 
   * No-change rebuild for CVE-2024-3094
diff --git a/debian/patches/implicit-declaration-in-configure.patch b/debian/patches/implicit-declaration-in-configure.patch
new file mode 100644
index 0000000..267e38f
--- /dev/null
+++ b/debian/patches/implicit-declaration-in-configure.patch
@@ -0,0 +1,202 @@
+Description: add missing headers to workaround -Werror=implicit-function-declaration
+Author: Vladimir Petko <[e-mail]>
+Origin: https://github.com/nmap/ncrack/pull/135
+Bug-Ubuntu: https://bugs.launchpad.net/ubuntu/+source/ncrack/+bug/2060908
+Bug-Debian: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1065799
+Bug: https://github.com/nmap/ncrack/issues/134
+Last-Update: 2024-04-12
+---
+diff --git a/opensshlib/configure.ac b/opensshlib/configure.ac
+index 3961df4..e8807eb 100644
+--- a/opensshlib/configure.ac
++++ b/opensshlib/configure.ac
+@@ -1111,7 +1111,10 @@ mips-sony-bsd|mips-sony-newsos4)
+ esac
+ 
+ AC_MSG_CHECKING([compiler and flags for sanity])
+-AC_RUN_IFELSE([AC_LANG_PROGRAM([[ #include <stdio.h> ]], [[ exit(0); ]])],
++AC_RUN_IFELSE([AC_LANG_PROGRAM([[
++#include <stdio.h>
++#include <stdlib.h>
++]], [[ exit(0); ]])],
+ 	[	AC_MSG_RESULT([yes]) ],
+ 	[
+ 		AC_MSG_RESULT([no])
+@@ -1349,6 +1352,7 @@ AC_MSG_CHECKING([whether struct dirent allocates space for d_name])
+ AC_RUN_IFELSE(
+ 	[AC_LANG_PROGRAM([[
+ #include <sys/types.h>
++#include <stdlib.h>
+ #include <dirent.h>]],
+ 	[[
+ 	struct dirent d;
+@@ -1944,7 +1948,10 @@ AC_CHECK_FUNC([getpagesize],
+ if test "x$ac_cv_func_snprintf" = "xyes" ; then
+ 	AC_MSG_CHECKING([whether snprintf correctly terminates long strings])
+ 	AC_RUN_IFELSE(
+-		[AC_LANG_PROGRAM([[ #include <stdio.h> ]],
++		[AC_LANG_PROGRAM([[
++#include <stdio.h>
++#include <stdlib.h>
++]],
+ 		[[
+ 	char b[5];
+ 	snprintf(b,5,"123456789");
+@@ -2346,6 +2353,7 @@ if test "x$openssl" = "xyes" ; then
+ 	AC_RUN_IFELSE(
+ 		[AC_LANG_PROGRAM([[
+ 	#include <stdio.h>
++	#include <stdlib.h>
+ 	#include <string.h>
+ 	#include <openssl/opensslv.h>
+ 	#define DATA "conftest.sslincver"
+@@ -2380,6 +2388,7 @@ if test "x$openssl" = "xyes" ; then
+ 	AC_RUN_IFELSE(
+ 		[AC_LANG_PROGRAM([[
+ 	#include <stdio.h>
++	#include <stdlib.h>
+ 	#include <string.h>
+ 	#define OPENSSL_API_COMPAT 0x10000000L
+ 	#include <openssl/opensslv.h>
+@@ -3186,6 +3195,7 @@ if test -z "$have_llong_max"; then
+ 	AC_RUN_IFELSE(
+ 		[AC_LANG_PROGRAM([[
+ #include <stdio.h>
++#include <stdlib.h>
+ /* Why is this so damn hard? */
+ #ifdef __GNUC__
+ # undef __GNUC__
+@@ -3644,6 +3654,7 @@ dnl test snprintf (broken on SCO w/gcc)
+ 	AC_RUN_IFELSE(
+ 		[AC_LANG_SOURCE([[
+ #include <stdio.h>
++#include <stdlib.h>
+ #include <string.h>
+ #ifdef HAVE_SNPRINTF
+ main()
+@@ -3701,6 +3712,7 @@ AC_CHECK_MEMBER([struct __res_state.retrans], [], [AC_DEFINE([__res_state], [sta
+ 	[Define if we don't have struct __res_state in resolv.h])],
+ [[
+ #include <stdio.h>
++#include <stdlib.h>
+ #if HAVE_SYS_TYPES_H
+ # include <sys/types.h>
+ #endif
+@@ -3744,6 +3756,7 @@ AC_CACHE_CHECK([for msg_accrights field in struct msghdr],
+ #include <sys/types.h>
+ #include <sys/socket.h>
+ #include <sys/uio.h>
++#include <stdlib.h>
+ 		]], [[
+ #ifdef msg_accrights
+ #error "msg_accrights is a macro"
+@@ -3804,6 +3817,7 @@ AC_CACHE_CHECK([for msg_control field in struct msghdr],
+ 	AC_COMPILE_IFELSE([AC_LANG_PROGRAM([[
+ #include <sys/types.h>
+ #include <sys/socket.h>
++#include <stdlib.h>
+ #include <sys/uio.h>
+ 		]], [[
+ #ifdef msg_control
+@@ -3825,7 +3839,7 @@ if test "x$ac_cv_have_control_in_msghdr" = "xyes" ; then
+ fi
+ 
+ AC_CACHE_CHECK([if libc defines __progname], ac_cv_libc_defines___progname, [
+-	AC_LINK_IFELSE([AC_LANG_PROGRAM([[]],
++	AC_LINK_IFELSE([AC_LANG_PROGRAM([[#include <stdio.h>]],
+ 		[[ extern char *__progname; printf("%s", __progname); ]])],
+ 	[ ac_cv_libc_defines___progname="yes" ],
+ 	[ ac_cv_libc_defines___progname="no" 
+@@ -3897,7 +3911,7 @@ if test "x$ac_cv_have_getopt_optreset" = "xyes" ; then
+ fi
+ 
+ AC_CACHE_CHECK([if libc defines sys_errlist], ac_cv_libc_defines_sys_errlist, [
+-	AC_LINK_IFELSE([AC_LANG_PROGRAM([[]],
++	AC_LINK_IFELSE([AC_LANG_PROGRAM([[#include <stdio.h>]],
+ [[ extern const char *const sys_errlist[]; printf("%s", sys_errlist[0]);]])],
+ 	[ ac_cv_libc_defines_sys_errlist="yes" ],
+ 	[ ac_cv_libc_defines_sys_errlist="no" 
+@@ -3910,7 +3924,7 @@ fi
+ 
+ 
+ AC_CACHE_CHECK([if libc defines sys_nerr], ac_cv_libc_defines_sys_nerr, [
+-	AC_LINK_IFELSE([AC_LANG_PROGRAM([[]],
++	AC_LINK_IFELSE([AC_LANG_PROGRAM([[#include <stdio.h>]],
+ [[ extern int sys_nerr; printf("%i", sys_nerr);]])],
+ 	[ ac_cv_libc_defines_sys_nerr="yes" ],
+ 	[ ac_cv_libc_defines_sys_nerr="no" 
+@@ -4220,6 +4234,7 @@ AC_ARG_WITH([maildir],
+ 	    AC_RUN_IFELSE(
+ 		[AC_LANG_PROGRAM([[
+ #include <stdio.h>
++#include <stdlib.h>
+ #include <string.h>
+ #ifdef HAVE_PATHS_H
+ #include <paths.h>
+@@ -4366,6 +4381,7 @@ if test -z "$disable_shadow" ; then
+ 	AC_MSG_CHECKING([if the systems has expire shadow information])
+ 	AC_COMPILE_IFELSE([AC_LANG_PROGRAM([[
+ #include <sys/types.h>
++#include <stdlib.h>
+ #include <shadow.h>
+ struct spwd sp;
+ 		]], [[ sp.sp_expire = sp.sp_lstchg = sp.sp_inact = 0; ]])],
+@@ -4464,6 +4480,7 @@ otherwise scp will not work.])
+ 			[AC_LANG_PROGRAM([[
+ /* find out what STDPATH is */
+ #include <stdio.h>
++#include <stdlib.h>
+ #ifdef HAVE_PATHS_H
+ # include <paths.h>
+ #endif
+diff --git a/opensshlib/configure.ac b/opensshlib/configure.ac
+index e8807eb..6b3be12 100644
+--- a/opensshlib/configure.ac
++++ b/opensshlib/configure.ac
+@@ -1853,6 +1853,9 @@ AC_CHECK_FUNCS([setresuid], [
+ 	AC_MSG_CHECKING([if setresuid seems to work])
+ 	AC_RUN_IFELSE(
+ 		[AC_LANG_PROGRAM([[
++#ifdef HAVE_UNISTD_H
++#include <unistd.h>
++#endif
+ #include <stdlib.h>
+ #include <errno.h>
+ 		]], [[
+@@ -1878,6 +1881,9 @@ AC_CHECK_FUNCS([setresgid], [
+ 		[AC_LANG_PROGRAM([[
+ #include <stdlib.h>
+ #include <errno.h>
++#ifdef HAVE_UNISTD_H
++#include <unistd.h>
++#endif
+ 		]], [[
+ 	errno=0;
+ 	setresgid(0,0,0);
+@@ -2042,6 +2048,9 @@ if test "x$ac_cv_func_mkdtemp" = "xyes" ; then
+ AC_MSG_CHECKING([for (overly) strict mkstemp])
+ AC_RUN_IFELSE(
+ 	[AC_LANG_PROGRAM([[
++#ifdef HAVE_UNISTD_H
++#include <unistd.h>
++#endif
+ #include <stdlib.h>
+ 	]], [[
+ 	char template[]="conftest.mkstemp-test";
+@@ -2070,6 +2079,13 @@ if test ! -z "$check_for_openpty_ctty_bug"; then
+ 	AC_RUN_IFELSE(
+ 		[AC_LANG_PROGRAM([[
+ #include <stdio.h>
++#include <stdlib.h>
++#ifdef HAVE_UNISTD_H
++#include <unistd.h>
++#endif
++#ifdef HAVE_PTY_H
++#include <pty.h>
++#endif
+ #include <sys/fcntl.h>
+ #include <sys/types.h>
+ #include <sys/wait.h>
+-- 
+2.40.1
+
diff --git a/debian/patches/series b/debian/patches/series
index 197a260..ce603cf 100644
--- a/debian/patches/series
+++ b/debian/patches/series
@@ -2,3 +2,4 @@ fix-gcc-10-build.patch
 fix-autotools-compat.patch
 fix-spelling-errors.patch
 allow-zlib-versions-with-two-part-version-number.patch
+implicit-declaration-in-configure.patch