Merge ~vpa1977/ubuntu/+source/libjxmpp-java:ubuntu/devel into ubuntu/+source/libjxmpp-java:ubuntu/devel

Proposed by Vladimir Petko
Status: Merged
Merge reported by: Vladimir Petko
Merged at revision: 9a65bac430b6ca7188583bb0759014845c56e1c1
Proposed branch: ~vpa1977/ubuntu/+source/libjxmpp-java:ubuntu/devel
Merge into: ubuntu/+source/libjxmpp-java:ubuntu/devel
Diff against target: 71 lines (+39/-1)
4 files modified
debian/changelog (+7/-0)
debian/control (+2/-1)
debian/patches/02-avoid-this-escape.patch (+29/-0)
debian/patches/series (+1/-0)
Reviewer Review Type Date Requested Status
Canonical Foundations Team Pending
git-ubuntu import Pending
Review via email: mp+460733@code.launchpad.net

Description of the change

This MP resolves Java 21 ftbfs.

PPA: ppa:vpa1977/gettext [1]

Changes:
 - Use java_compat_level variable provided by java-common to adjust -source/-target level to the minimum required by the default Java

Testing:
 - rebuild in default Java 21 ppa[2]
 - piuparts test [3]

[1] https://launchpad.net/~vpa1977/+archive/ubuntu/gettext
[2] https://launchpad.net/~vpa1977/+archive/ubuntu/gettext-21/+sourcepub/15798706/+listing-archive-extra
[3] https://bugs.launchpad.net/ubuntu/+source/libjxmpp-java/+bug/2054240/comments/1

To post a comment you must log in.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/debian/changelog b/debian/changelog
2index fca8f16..e4c46a6 100644
3--- a/debian/changelog
4+++ b/debian/changelog
5@@ -1,3 +1,10 @@
6+libjxmpp-java (1.0.1-3ubuntu1) noble; urgency=medium
7+
8+ * d/p/02-avoid-this-escape.patch: apply upstream fix to resolve Java
9+ 21 ftbfs (LP: #2054240).
10+
11+ -- Vladimir Petko <vladimir.petko@canonical.com> Mon, 19 Feb 2024 10:07:15 +1300
12+
13 libjxmpp-java (1.0.1-3) unstable; urgency=medium
14
15 * Don't build jxmpp-stringprep-libidn
16diff --git a/debian/control b/debian/control
17index a965fac..69cad86 100644
18--- a/debian/control
19+++ b/debian/control
20@@ -1,7 +1,8 @@
21 Source: libjxmpp-java
22 Section: java
23 Priority: optional
24-Maintainer: Debian Java Maintainers <pkg-java-maintainers@lists.alioth.debian.org>
25+Maintainer: Ubuntu Developers <ubuntu-devel-discuss@lists.ubuntu.com>
26+XSBC-Original-Maintainer: Debian Java Maintainers <pkg-java-maintainers@lists.alioth.debian.org>
27 Uploaders:
28 Sunil Mohan Adapa <sunil@medhas.org>,
29 James Valleroy <jvalleroy@mailbox.org>
30diff --git a/debian/patches/02-avoid-this-escape.patch b/debian/patches/02-avoid-this-escape.patch
31new file mode 100644
32index 0000000..eb1c1d5
33--- /dev/null
34+++ b/debian/patches/02-avoid-this-escape.patch
35@@ -0,0 +1,29 @@
36+Description: workaround this-escape warnings for Java 21
37+ Workaround this-escape warning for Java 21 (declare final or
38+ suppress the warning where inheritance is present).
39+Author: Vladimir Petko <vladimir.petko@canonical.com>
40+Bug: https://github.com/igniterealtime/jxmpp/pull/43
41+Bug-Debian: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1057520
42+Bug-Ubuntu: https://bugs.launchpad.net/debian/+source/libjxmpp-java/+bug/2054240
43+Last-Update: 2024-01-30
44+--- a/jxmpp-util-cache/src/main/java/org/jxmpp/util/cache/ExpirationCache.java
45++++ b/jxmpp-util-cache/src/main/java/org/jxmpp/util/cache/ExpirationCache.java
46+@@ -43,7 +43,7 @@
47+ *
48+ * @param defaultExpirationTime the default expiration time.
49+ */
50+- public void setDefaultExpirationTime(long defaultExpirationTime) {
51++ public final void setDefaultExpirationTime(long defaultExpirationTime) {
52+ if (defaultExpirationTime <= 0) {
53+ throw new IllegalArgumentException();
54+ }
55+--- a/jxmpp-core/src/main/java/org/jxmpp/stringprep/XmppStringprepException.java
56++++ b/jxmpp-core/src/main/java/org/jxmpp/stringprep/XmppStringprepException.java
57+@@ -36,6 +36,7 @@
58+ * @param causingString the String causing the exception.
59+ * @param exception the exception.
60+ */
61++ @SuppressWarnings("this-escape")
62+ public XmppStringprepException(String causingString, Exception exception) {
63+ super("XmppStringprepException caused by '" + causingString + "': " + exception);
64+ initCause(exception);
65diff --git a/debian/patches/series b/debian/patches/series
66index 4be79a9..61299b2 100644
67--- a/debian/patches/series
68+++ b/debian/patches/series
69@@ -1 +1,2 @@
70 01-edit-build-system.patch
71+02-avoid-this-escape.patch

Subscribers

People subscribed via source and target branches