Merge ~vpa1977/ubuntu/+source/condor:fix-depends into ubuntu/+source/condor:ubuntu/devel

Proposed by Vladimir Petko
Status: Work in progress
Proposed branch: ~vpa1977/ubuntu/+source/condor:fix-depends
Merge into: ubuntu/+source/condor:ubuntu/devel
Diff against target: 55 lines (+15/-3)
3 files modified
debian/changelog (+6/-0)
debian/control (+2/-3)
debian/rules (+7/-0)
Reviewer Review Type Date Requested Status
git-ubuntu import Pending
Review via email: mp+462997@code.launchpad.net

Description of the change

Changes:
     - Derive the library name from the -dev package, add a b-d on the -dev package, replace the hard coded library in the control file with a macro, and pass that macro in dh_gencontrol.

PPA: ppa:vpa1977/october-21-2 [1]

Tests:
 - package builds
 - package installs on arhmf:
---
apt install condor=23.4.0+dfsg-1ubuntu2~ppa2
Reading package lists... Done
Building dependency tree... Done
Reading state information... Done
The following additional packages will be installed:
  fonts-glyphicons-halflings libboost-python1.83.0 libdate-manip-perl libjs-bootstrap libmunge2 libscitokens0t64 libvomsapi1t64 net-tools
Suggested packages:
  docker.io coop-computing-tools singularity-container slurm-client
The following NEW packages will be installed:
  condor fonts-glyphicons-halflings libboost-python1.83.0 libdate-manip-perl libjs-bootstrap libmunge2 libscitokens0t64 libvomsapi1t64 net-tools
0 upgraded, 9 newly installed, 0 to remove and 61 not upgraded.
Need to get 10.4 MB of archives.
After this operation, 38.9 MB of additional disk space will be used.
Do you want to continue? [Y/n]
....
Processing triggers for libc-bin (2.39-0ubuntu6) ...
----

[1] https://launchpad.net/~vpa1977/+archive/ubuntu/october-21-2

To post a comment you must log in.
0b824a0... by Vladimir Petko

  * Don't hard-code dependency on a shared library (LP: 2058880).

e5f6e5f... by Vladimir Petko

changelog

Unmerged commits

e5f6e5f... by Vladimir Petko

changelog

0b824a0... by Vladimir Petko

  * Don't hard-code dependency on a shared library (LP: 2058880).

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/debian/changelog b/debian/changelog
2index 8ebc570..5f71a0a 100644
3--- a/debian/changelog
4+++ b/debian/changelog
5@@ -1,3 +1,9 @@
6+condor (23.4.0+dfsg-1ubuntu2) noble; urgency=medium
7+
8+ * Don't hard-code dependency on a shared library (LP: #2058880).
9+
10+ -- Vladimir Petko <vladimir.petko@canonical.com> Mon, 25 Mar 2024 15:56:46 +1300
11+
12 condor (23.4.0+dfsg-1ubuntu1) noble; urgency=high
13
14 * Bump dependency to libssl3t64.
15diff --git a/debian/control b/debian/control
16index 854f423..8643537 100644
17--- a/debian/control
18+++ b/debian/control
19@@ -25,6 +25,7 @@ Build-Depends: cmake (>= 3.16),
20 libpcre2-dev,
21 libpq-dev,
22 libscitokens-dev,
23+ libssl-dev,
24 libsqlite3-dev,
25 libsystemd-dev,
26 libvirt-dev,
27@@ -59,12 +60,10 @@ Depends: adduser,
28 libkrb5-3,
29 libkrb5support0,
30 libmunge2,
31- libssl3t64,
32- libscitokens0,
33- libvomsapi1v5,
34 net-tools,
35 libjs-bootstrap,
36 libjs-jquery,
37+ ${lib:Depends},
38 ${misc:Depends},
39 ${perl:Depends},
40 ${python3:Depends},
41diff --git a/debian/rules b/debian/rules
42index 616641c..319c3bd 100755
43--- a/debian/rules
44+++ b/debian/rules
45@@ -132,3 +132,10 @@ override_dh_strip:
46
47 override_dh_auto_test:
48
49+override_dh_gencontrol:
50+ dh_gencontrol -- \
51+ -Vlib:Depends="$(foreach package, libscitokens libssl, \
52+ $(shell dpkg-query -W -f '$${Depends}' $(package)-dev \
53+ | sed -E 's/.*($(package)[[:alnum:].-]+).*/\1,/' )) \
54+ $(shell dpkg-query -W -f '$${Depends}' voms-dev \
55+ | sed -E 's/.*(libvomsapi[[:alnum:].-]+).*/\1,/' )"

Subscribers

People subscribed via source and target branches