Merge ~vpa1977/ubuntu/+source/coco-java:ubuntu/devel into ubuntu/+source/coco-java:ubuntu/devel

Proposed by Vladimir Petko
Status: Needs review
Proposed branch: ~vpa1977/ubuntu/+source/coco-java:ubuntu/devel
Merge into: ubuntu/+source/coco-java:ubuntu/devel
Diff against target: 43 lines (+11/-3)
3 files modified
debian/changelog (+8/-0)
debian/patches/debian.patch (+1/-1)
debian/rules (+2/-2)
Reviewer Review Type Date Requested Status
Julian Andres Klode (community) Approve
git-ubuntu import Pending
Review via email: mp+460418@code.launchpad.net

Description of the change

This MP resolves Java 21 ftbfs.

PPA: ppa:vpa1977/gettext [1]

Changes:
 - Use java_compat_level variable provided by java-common to adjust -source/-target level to the minimum required by the default Java

Testing:
 - rebuild in default Java 21 ppa[2]
 - piuparts test [3]

[1] https://launchpad.net/~vpa1977/+archive/ubuntu/gettext
[2] https://launchpad.net/~vpa1977/+archive/ubuntu/gettext-21/+sourcepub/15785386/+listing-archive-extra
[3] https://bugs.launchpad.net/ubuntu/+source/coco-java/+bug/2052987/comments/1

To post a comment you must log in.
Revision history for this message
Julian Andres Klode (juliank) wrote :

Uploaded, thanks

review: Approve

Unmerged commits

5b527d4... by Vladimir Petko

changelog

26b95da... by Vladimir Petko

Use JAVA_COMPAT_LEVEL to set -source/-target

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/debian/changelog b/debian/changelog
2index 885bf27..af01011 100644
3--- a/debian/changelog
4+++ b/debian/changelog
5@@ -1,3 +1,11 @@
6+coco-java (20110419-4ubuntu1) noble; urgency=medium
7+
8+ * d/p/debian.patch, d/rules: use java_compat_level variable provided
9+ by java-common to adjust -source/-target level to the minimum
10+ required by the default Java (LP: #2052987).
11+
12+ -- Vladimir Petko <vladimir.petko@canonical.com> Wed, 22 Nov 2023 10:42:13 +1300
13+
14 coco-java (20110419-4) unstable; urgency=medium
15
16 * QA upload.
17diff --git a/debian/patches/debian.patch b/debian/patches/debian.patch
18index ea38da9..f245c75 100644
19--- a/debian/patches/debian.patch
20+++ b/debian/patches/debian.patch
21@@ -2,7 +2,7 @@
22 +++ coco-java-20110419/Makefile
23 @@ -0,0 +1,13 @@
24 +all:
25-+ javac -d . -source 1.7 -target 1.7 Trace.java Scanner.java Tab.java DFA.java ParserGen.java Parser.java Coco.java
26++ javac -d . -source $$JAVA_COMPAT_LEVEL -target $$JAVA_COMPAT_LEVEL Trace.java Scanner.java Tab.java DFA.java ParserGen.java Parser.java Coco.java
27 + jar cfm Coco.jar Coco.manifest Coco/*.class
28 + rm -rf Coco
29 +
30diff --git a/debian/rules b/debian/rules
31index 6e052c2..b783118 100755
32--- a/debian/rules
33+++ b/debian/rules
34@@ -9,8 +9,8 @@
35 # Uncomment this to turn on verbose mode.
36 #export DH_VERBOSE=1
37
38-
39-
40+include /usr/share/java/java_defaults.mk
41+export JAVA_COMPAT_LEVEL=$(java_compat_level)
42
43 CFLAGS = -Wall -g
44

Subscribers

People subscribed via source and target branches