Merge ~vpa1977/ubuntu/+source/byte-buddy:fix-bytebuddy-depends into ubuntu/+source/byte-buddy:ubuntu/devel

Proposed by Vladimir Petko
Status: Needs review
Proposed branch: ~vpa1977/ubuntu/+source/byte-buddy:fix-bytebuddy-depends
Merge into: ubuntu/+source/byte-buddy:ubuntu/devel
Diff against target: 38 lines (+16/-0)
2 files modified
debian/changelog (+9/-0)
debian/rules (+7/-0)
Reviewer Review Type Date Requested Status
Zixing Liu (community) Approve
git-ubuntu import Pending
Review via email: mp+460891@code.launchpad.net

Description of the change

This MP fixes too strict version dependency on byte-buddy generated by maven-debian-helper.

Changes:
 - Replace pom version in debian.originalVersion with changelog upstream version including repack suffix.

PPA: ppa:vpa1977/byte-buddy-fix[1]

Testing:
 - piuparts test for the package itself [2]
 - rebuild easymock and check libbyte-buddy-java version in control file depends field.
'Depends: libasm-java (>= 9.6~us1), libbyte-buddy-java (>= 1.14.11~us1), libobjenesis-java (>= 3.3)'
 - build libgoby-java (build depends on easymock) [3]

[1] https://launchpad.net/~vpa1977/+archive/ubuntu/byte-buddy-fix
[2] https://bugs.launchpad.net/ubuntu/+source/byte-buddy/+bug/2054488/comments/2
[3] https://launchpadlibrarian.net/715490126/buildlog_ubuntu-noble-amd64.libgoby-java_3.3.1+dfsg2-10build1~ppa1_BUILDING.txt.gz

To post a comment you must log in.
Revision history for this message
Vladimir Petko (vpa1977) wrote (last edit ):

Pushed separator change suggested by liushuyu-011, retested - the dependency for easymock is created correctly -
'Depends: libasm-java (>= 9.6~us1), libbyte-buddy-java (>= 1.14.11~us1), libobjenesis-java (>= 3.3)'

Also rephrased changelog as per grammarly.

Revision history for this message
Zixing Liu (liushuyu-011) wrote :

Looks good to me

review: Approve
Revision history for this message
Vladimir Petko (vpa1977) wrote :

Uploaded, thank you!

Unmerged commits

bbb2a84... by Vladimir Petko

changelog

e03e966... by Vladimir Petko

replace pom version with the changelog version

314d2b7... by Vladimir Petko

1.14.11~us1-0ubuntu1 (patches unapplied)

Imported using git-ubuntu import.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/debian/changelog b/debian/changelog
2index b07ff04..107a7ff 100644
3--- a/debian/changelog
4+++ b/debian/changelog
5@@ -1,3 +1,12 @@
6+byte-buddy (1.14.11~us1-0ubuntu2) noble; urgency=medium
7+
8+ * d/rules: replace the pom version with the changelog version to
9+ include a repack suffix (LP: #2054488). This change fixes
10+ the inability to install byte-buddy dependencies after rebuild
11+ due to binary dependency on byte-buddy >= 1.14.11.
12+
13+ -- Vladimir Petko <vladimir.petko@canonical.com> Wed, 21 Feb 2024 18:27:13 +1300
14+
15 byte-buddy (1.14.11~us1-0ubuntu1) noble; urgency=medium
16
17 * New upstream release (LP: #2051752):
18diff --git a/debian/rules b/debian/rules
19index f81bf7c..8912398 100755
20--- a/debian/rules
21+++ b/debian/rules
22@@ -1,5 +1,7 @@
23 #!/usr/bin/make -f
24
25+v_upstream=$(shell dpkg-parsechangelog -S Version| sed 's/-[^-][^-]*$$//')
26+
27 %:
28 dh $@
29
30@@ -24,3 +26,8 @@ override_dh_auto_test:
31 # Do not run 'mvn test', even if the tests are disabled in debian/maven.properties
32 # it performs a second bytecode transformation and the build break due to duplicate
33 # fields introduced by net.bytebuddy.build.CachedReturnPlugin
34+
35+override_dh_auto_install:
36+ dh_auto_install
37+
38+ find debian/libbyte-buddy-java/usr/share/maven-repo -exec sed -i 's|debian.originalVersion>.*<|debian.originalVersion>$(v_upstream)<|g' {} \;

Subscribers

People subscribed via source and target branches