Merge ~vpa1977/ubuntu/+source/antlr-maven-plugin:java21-ftbfs into ubuntu/+source/antlr-maven-plugin:ubuntu/devel

[Vladimir Petko]

This MP resolves Java 21 ftbfs.

PPA: ppa:vpa1977/gettext [1]

Changes:
 - add patch to catch UnsupportedOperationException.

Testing:
 - rebuild in default Java 21 ppa[2]
 - piuparts test [3]
Note:
 - the upstream for the plugin is no longer available (codehouse.org)
 - the plugin is still used by apache projects that are reverse build dependencies[1] and present in the archive[5]

[1] https://launchpad.net/~vpa1977/+archive/ubuntu/gettext
[2] https://launchpad.net/~vpa1977/+archive/ubuntu/gettext-21/+sourcepub/15786613/+listing-archive-extra
[3] https://bugs.launchpad.net/ubuntu/+source/antlr-maven-plugin/+bug/2052993/comments/1
[4] https://github.com/apache/directory-ldap-api/blob/master/pom.xml#L271
[5] https://sources.debian.org/src/apache-directory-api/2.1.2-1/debian/control/#L10

[Julian Andres Klode (juliank)]

Uploaded, thanks

review: Approve

diff --git a/debian/changelog b/debian/changelog
index 61b9d40..5c3646b 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,11 @@
+antlr-maven-plugin (2.2-5ubuntu1) noble; urgency=medium
+
+  * d/p/security-manager.patch: catch UnsupportedOperationException
+    thrown by Java 21 setSecurityManager() method to resolve ftbfs
+    (LP: #2052993).
+
+ -- Vladimir Petko <[e-mail]>  Tue, 13 Feb 2024 17:45:22 +1300
+
 antlr-maven-plugin (2.2-5) unstable; urgency=medium
 
   * Fixed the build failure with doxia 1.11
diff --git a/debian/control b/debian/control
index d2c2ab1..0a8896e 100644
--- a/debian/control
+++ b/debian/control
@@ -1,7 +1,8 @@
 Source: antlr-maven-plugin
 Section: java
 Priority: optional
-Maintainer: Debian Java Maintainers <[e-mail]>
+Maintainer: Ubuntu Developers <[e-mail]>
+XSBC-Original-Maintainer: Debian Java Maintainers <[e-mail]>
 Uploaders:
  Ludovic Claude <[e-mail]>,
  Torsten Werner <[e-mail]>,
diff --git a/debian/patches/security-manager.patch b/debian/patches/security-manager.patch
new file mode 100644
index 0000000..4a2ad33
--- /dev/null
+++ b/debian/patches/security-manager.patch
@@ -0,0 +1,23 @@
+Description: catch SecurityManager exception
+ When Java 21 is called without -Djava.security.manager property,
+ UnsupportedOperationException is thrown in setSecurityManager() method.
+ The plugin uses Security Manager to avoid shutting down Java machine on error,
+ but gracefully handles situation when it can not be set.
+ The patch is not forwarded as upstream is no longer available, but the
+ plugin is still used by reverse build dependencies.
+Author: Vladimir Petko <[e-mail]>
+Bug-Ubuntu: https://bugs.launchpad.net/ubuntu/+source/antlr-maven-plugin/+bug/2052993
+Bug-Debian: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1053206
+Forwarded: not-needed
+Last-Update: 2024-02-13
+--- a/src/main/java/org/codehaus/mojo/antlr/AbstractAntlrMojo.java
++++ b/src/main/java/org/codehaus/mojo/antlr/AbstractAntlrMojo.java
+@@ -337,7 +337,7 @@
+             oldSm = System.getSecurityManager();
+             System.setSecurityManager( NoExitSecurityManager.INSTANCE );
+         }
+-        catch ( SecurityException ex )
++        catch ( UnsupportedOperationException | SecurityException ex )
+         {
+             // ANTLR-12
+             oldSm = null;
diff --git a/debian/patches/series b/debian/patches/series
index ac07961..3d2a45d 100644
--- a/debian/patches/series
+++ b/debian/patches/series
@@ -1,2 +1,3 @@
 null-options-check.patch
 modello-1.1.patch
+security-manager.patch