Merge lp:~vorlon/xdeb/xdeb-graph-harder into lp:~wookey/xdeb/xdeb-graph

Proposed by Steve Langasek
Status: Needs review
Proposed branch: lp:~vorlon/xdeb/xdeb-graph-harder
Merge into: lp:~wookey/xdeb/xdeb-graph
Diff against target: 21 lines (+2/-2)
1 file modified
xdeb.py (+2/-2)
To merge this branch: bzr merge lp:~vorlon/xdeb/xdeb-graph-harder
Reviewer Review Type Date Requested Status
Wookey Disapprove
Review via email: mp+52900@code.launchpad.net

Description of the change

A few fixes to the xdeb-graph branch

To post a comment you must log in.
lp:~vorlon/xdeb/xdeb-graph-harder updated
259. By Steve Langasek

sync up with the xdeb-graph branch

Revision history for this message
Wookey (wookey) wrote :

This fix wasn't right. (or at least the 'not' wasn't. susumed into the xdeb-graph branch and then trunk so this branch now irrelevant.

review: Disapprove

Unmerged revisions

259. By Steve Langasek

sync up with the xdeb-graph branch

258. By Steve Langasek

break out of the or_deps loop any time we find an available alternative,
not just when we find one we haven't seen previously.

257. By Steve Langasek

correct an inversion overlooked when refactoring expand_depends

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'xdeb.py'
2--- xdeb.py 2011-03-10 23:02:42 +0000
3+++ xdeb.py 2011-03-10 23:35:09 +0000
4@@ -294,7 +294,7 @@
5 # what is built can be installed. However we only want to do this
6 # for binary deps that are actually needed as build-deps
7 for binary in get_src_binaries(options, src):
8- if binary in builddep_pkgs:
9+ if binary not in builddep_pkgs:
10 continue
11 if not is_crossable(binary) or is_toolchain(binary):
12 continue
13@@ -323,7 +323,7 @@
14 expand_depends(options, graph_pkg, real_dep, depth + 1,
15 builddep_depth,
16 parent=src, parent_binary=binary)
17- break
18+ break
19
20 def mark_needs_build(options, src, force=False):
21 """Decide whether a package needs to be (re)built."""

Subscribers

People subscribed via source and target branches

to all changes: