Merge lp:~vorlon/upstart/more-log-flushing-tests into lp:upstart
Proposed by
Steve Langasek
Status: | Merged |
---|---|
Merged at revision: | 1578 |
Proposed branch: | lp:~vorlon/upstart/more-log-flushing-tests |
Merge into: | lp:upstart |
Diff against target: |
62 lines (+22/-2) 2 files modified
ChangeLog (+7/-0) init/tests/test_log.c (+15/-2) |
To merge this branch: | bzr merge lp:~vorlon/upstart/more-log-flushing-tests |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
James Hunt | Approve | ||
Review via email: mp+196432@code.launchpad.net |
Description of the change
As with lp:~vorlon/upstart/flaky-log-serialization-test, some of the tests
in test_log.c fail because they assume the specified log file will not be
writable. This is not always the case, even if the target file is in the
root directory! So instead, if we don't want the log to be flushed, create
our own file and make sure it's inacessible.
To post a comment you must log in.
LGTM - merged.