Merge lp:~vorlon/ubuntu/trusty/dpkg/lp.1279128 into lp:ubuntu/trusty/dpkg

Proposed by Steve Langasek
Status: Rejected
Rejected by: Adam Conrad
Proposed branch: lp:~vorlon/ubuntu/trusty/dpkg/lp.1279128
Merge into: lp:ubuntu/trusty/dpkg
Diff against target: 37 lines (+12/-0)
2 files modified
debian/changelog (+7/-0)
scripts/Dpkg/BuildFlags.pm (+5/-0)
To merge this branch: bzr merge lp:~vorlon/ubuntu/trusty/dpkg/lp.1279128
Reviewer Review Type Date Requested Status
Matthias Klose Pending
Review via email: mp+205878@code.launchpad.net

Description of the change

proposed fix for bug #1279128, please review

To post a comment you must log in.
Revision history for this message
Adam Conrad (adconrad) wrote :

Fixed differently in an archive upload.

Unmerged revisions

202. By Steve Langasek

Set the default optimization in dpkg-buildflags to -O3 on ppc64 and
ppc64el, instead of -O2. LP: #1279128.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2014-02-05 07:26:29 +0000
3+++ debian/changelog 2014-02-12 00:39:55 +0000
4@@ -1,3 +1,10 @@
5+dpkg (1.17.5ubuntu4) UNRELEASED; urgency=medium
6+
7+ * Set the default optimization in dpkg-buildflags to -O3 on ppc64 and
8+ ppc64el, instead of -O2. LP: #1279128.
9+
10+ -- Steve Langasek <steve.langasek@ubuntu.com> Wed, 12 Feb 2014 00:37:02 +0000
11+
12 dpkg (1.17.5ubuntu3) trusty; urgency=medium
13
14 * Change native source version/format mismatch errors into warnings until
15
16=== modified file 'scripts/Dpkg/BuildFlags.pm'
17--- scripts/Dpkg/BuildFlags.pm 2013-12-07 07:34:54 +0000
18+++ scripts/Dpkg/BuildFlags.pm 2014-02-12 00:39:55 +0000
19@@ -25,6 +25,7 @@
20 use Dpkg::BuildEnv;
21 use Dpkg::BuildOptions;
22 use Dpkg::ErrorHandling;
23+use Dpkg::Arch qw(get_host_arch);
24 use Dpkg::Vendor qw(run_vendor_hook);
25
26 =encoding utf8
27@@ -74,6 +75,10 @@
28 my $build_opts = Dpkg::BuildOptions->new();
29 $self->{build_options} = $build_opts;
30 my $default_flags = $build_opts->has('noopt') ? '-g -O0' : '-g -O2';
31+ my $arch = get_host_arch();
32+ if ($arch eq 'ppc64' || $arch eq 'ppc64el') {
33+ $default_flags = $build_opts->has('noopt') ? '-g -O0' : '-g -O3';
34+ }
35 $self->{flags} = {
36 CPPFLAGS => '',
37 CFLAGS => $default_flags,

Subscribers

People subscribed via source and target branches