Merge lp:~vorlon/ubuntu-qa-website/https into lp:ubuntu-qa-website

Proposed by Steve Langasek
Status: Merged
Merged at revision: 434
Proposed branch: lp:~vorlon/ubuntu-qa-website/https
Merge into: lp:ubuntu-qa-website
Diff against target: 124 lines (+11/-11)
8 files modified
modules/qatracker/admin/qatracker.admin.sites.php (+1/-1)
modules/qatracker/qatracker.functions.php (+2/-2)
modules/qatracker/report/qatracker.report.bugs.php (+1/-1)
modules/qatracker/report/qatracker.report.defects.php (+1/-1)
modules/qatracker/report/qatracker.report.subscriptions.php (+1/-1)
modules/qatracker/report/qatracker.report.testers.php (+1/-1)
modules/qatracker/user/qatracker.user.results.php (+2/-2)
scripts/sync-lp-bugs (+2/-2)
To merge this branch: bzr merge lp:~vorlon/ubuntu-qa-website/https
Reviewer Review Type Date Requested Status
Paride Legovini Approve
Review via email: mp+427237@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Paride Legovini (paride) wrote :

LGTM, thanks Steve.

review: Approve
Revision history for this message
Paride Legovini (paride) wrote :

After merging there we'll need to somehow deploy the change to production, I suppose. We (Ubuntu QA) will try to figure it out after the Jammy point release: better not to break everything this week.

Revision history for this message
Brian Murray (brian-murray) wrote :

The actual update of the site is being tracked in RT 152584.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'modules/qatracker/admin/qatracker.admin.sites.php'
2--- modules/qatracker/admin/qatracker.admin.sites.php 2012-09-19 21:14:48 +0000
3+++ modules/qatracker/admin/qatracker.admin.sites.php 2022-07-21 17:36:53 +0000
4@@ -36,7 +36,7 @@
5 foreach ($result as $record) {
6 $rows[] = array(
7 $record->title,
8- l($record->subdomain, "http://".$record->subdomain),
9+ l($record->subdomain, "https://".$record->subdomain),
10 array_key_exists($record->userrole, $mapping) ? $mapping[$record->userrole] : $record->userrole,
11 array_key_exists($record->adminrole, $mapping) ? $mapping[$record->adminrole] : $record->adminrole,
12 array_key_exists($record->testcaserole, $mapping) ? $mapping[$record->testcaserole] : $record->testcaserole,
13
14=== modified file 'modules/qatracker/qatracker.functions.php'
15--- modules/qatracker/qatracker.functions.php 2016-01-20 07:59:52 +0000
16+++ modules/qatracker/qatracker.functions.php 2022-07-21 17:36:53 +0000
17@@ -90,7 +90,7 @@
18 <br />
19 ".t("Bug information are updated every 5 minutes.")."
20 </div>
21- <a class=\"blacklink\" rel=\"external\" href=\"http://launchpad.net/bugs/".$bug->originalbug."\">$icon</a>
22+ <a class=\"blacklink\" rel=\"external\" href=\"https://launchpad.net/bugs/".$bug->originalbug."\">$icon</a>
23 </div>";
24 }
25 else {
26@@ -129,7 +129,7 @@
27 )."
28 </i>
29 </div>
30- <a class=\"blacklink\" rel=\"external\" href=\"http://launchpad.net/bugs/".$bug->bugnumber."\">$icon</a>
31+ <a class=\"blacklink\" rel=\"external\" href=\"https://launchpad.net/bugs/".$bug->bugnumber."\">$icon</a>
32 </div>";
33 }
34 }
35
36=== modified file 'modules/qatracker/report/qatracker.report.bugs.php'
37--- modules/qatracker/report/qatracker.report.bugs.php 2012-11-19 20:35:32 +0000
38+++ modules/qatracker/report/qatracker.report.bugs.php 2022-07-21 17:36:53 +0000
39@@ -64,7 +64,7 @@
40 return $items;
41 }
42
43- drupal_set_title(t("List of results for !bug (and its duplicates)", array("!bug" => l("bug #".arg(3), "http://bugs.launchpad.net/bugs/".arg(3)))), $output = PASS_THROUGH);
44+ drupal_set_title(t("List of results for !bug (and its duplicates)", array("!bug" => l("bug #".arg(3), "https://bugs.launchpad.net/bugs/".arg(3)))), $output = PASS_THROUGH);
45
46 # Getting all the entries
47 $query = db_select('qatracker_launchpad_bug');
48
49=== modified file 'modules/qatracker/report/qatracker.report.defects.php'
50--- modules/qatracker/report/qatracker.report.defects.php 2016-03-24 13:52:19 +0000
51+++ modules/qatracker/report/qatracker.report.defects.php 2022-07-21 17:36:53 +0000
52@@ -160,7 +160,7 @@
53 $rows[] = array(
54 'data' => array(
55 l($record->bugnumber,
56- 'http://bugs.launchpad.net/bugs/' . $record->bugnumber),
57+ 'https://bugs.launchpad.net/bugs/' . $record->bugnumber),
58 $record->btitle,
59 str_replace(' (Ubuntu)', '', $record->product),
60 $record->status,
61
62=== modified file 'modules/qatracker/report/qatracker.report.subscriptions.php'
63--- modules/qatracker/report/qatracker.report.subscriptions.php 2012-11-19 20:35:32 +0000
64+++ modules/qatracker/report/qatracker.report.subscriptions.php 2022-07-21 17:36:53 +0000
65@@ -157,7 +157,7 @@
66 $rows = array();
67 foreach ($users_result as $entry) {
68 #FIXME: hardcoded launchpad.net
69- $rows[] = array(l($entry->name, "http://launchpad.net/~".$entry->name), $entry->count);
70+ $rows[] = array(l($entry->name, "https://launchpad.net/~".$entry->name), $entry->count);
71 }
72
73 $items[] = array(
74
75=== modified file 'modules/qatracker/report/qatracker.report.testers.php'
76--- modules/qatracker/report/qatracker.report.testers.php 2015-12-13 21:40:21 +0000
77+++ modules/qatracker/report/qatracker.report.testers.php 2022-07-21 17:36:53 +0000
78@@ -99,7 +99,7 @@
79 # hardcoding Launchpad
80 $rows[] = array(
81 $position,
82- l($record->name, "http://launchpad.net/~".$record->name),
83+ l($record->name, "https://launchpad.net/~".$record->name),
84 $record->count,
85 );
86 if (arg(3) != "top100") {
87
88=== modified file 'modules/qatracker/user/qatracker.user.results.php'
89--- modules/qatracker/user/qatracker.user.results.php 2016-01-20 21:11:19 +0000
90+++ modules/qatracker/user/qatracker.user.results.php 2022-07-21 17:36:53 +0000
91@@ -410,7 +410,7 @@
92 # hardcoding Launchpad
93 $data = array(
94 $icon,
95- l($account->name, "http://launchpad.net/~".$account->name),
96+ l($account->name, "https://launchpad.net/~".$account->name),
97 format_date(strtotime($record->last_touched), 'short'),
98 array('data' => $bugs, 'style' => 'text-align:center;'),
99 check_markup($record->comment),
100@@ -880,7 +880,7 @@
101 foreach ($bugs as $bug) {
102 if (!empty($bug->bugnumber)) {
103 $rows[] = array(
104- '<a href="http://launchpad.net/bugs/'.$bug->bugnumber.'">'.$bug->bugnumber.'</a>',
105+ '<a href="https://launchpad.net/bugs/'.$bug->bugnumber.'">'.$bug->bugnumber.'</a>',
106 $bug->title,
107 $bug->status,
108 $bug->importance,
109
110=== modified file 'scripts/sync-lp-bugs'
111--- scripts/sync-lp-bugs 2017-03-29 16:56:36 +0000
112+++ scripts/sync-lp-bugs 2022-07-21 17:36:53 +0000
113@@ -153,9 +153,9 @@
114
115 site_comment = None
116 site_tags = None
117- site_rpc = xmlrpclib.ServerProxy("http://%s/xmlrpc.php" %
118+ site_rpc = xmlrpclib.ServerProxy("https://%s/xmlrpc.php" %
119 site_domain).qatracker
120- site_bugurl = "http://%s/qatracker/reports/bugs" % site_domain
121+ site_bugurl = "https://%s/qatracker/reports/bugs" % site_domain
122
123 # Start by looking for the site in the database
124 site_dbrecords = store.find(Site, subdomain=unicode(site_domain))

Subscribers

People subscribed via source and target branches