Merge lp:~vorlon/ubuntu-cdimage/public-info-out-of-private-production into lp:ubuntu-cdimage

Proposed by Steve Langasek on 2017-05-16
Status: Merged
Merged at revision: 1666
Proposed branch: lp:~vorlon/ubuntu-cdimage/public-info-out-of-private-production
Merge into: lp:ubuntu-cdimage
Diff against target: 51 lines (+36/-0)
2 files modified
etc/livefs-launchpad (+34/-0)
lib/cdimage/livefs.py (+2/-0)
To merge this branch: bzr merge lp:~vorlon/ubuntu-cdimage/public-info-out-of-private-production
Reviewer Review Type Date Requested Status
Adam Conrad 2017-05-16 Approve on 2017-05-16
Review via email: mp+324120@code.launchpad.net
To post a comment you must log in.
Steve Langasek (vorlon) wrote :

If this approach is palatable, I would want to do the same for production/current-triggers, which we have a history of failing to update at the start of the cycle. (But also, it would be good to make the format of current-triggers match that of livefs-launchpad and etc/default-arches, so that defaults can be inherited across releases...)

Steve Langasek (vorlon) wrote :

well, that last bit should be a one-liner change, so separate MP raised already at https://code.launchpad.net/~vorlon/ubuntu-cdimage/match-series-for-current-triggers/+merge/324123

Adam Conrad (adconrad) wrote :

Seems entirely reasonable to me. I'm not going to review the file itself, assuming that it's a straight cp -a from production.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== added file 'etc/livefs-launchpad'
2--- etc/livefs-launchpad 1970-01-01 00:00:00 +0000
3+++ etc/livefs-launchpad 2017-05-16 16:20:32 +0000
4@@ -0,0 +1,34 @@
5+# PROJECT IMAGE_TYPE DIST ARCH [INSTANCE/]OWNER/NAME
6+# Put more specific matches first.
7+# Like etc/default-arches, "PROJECT" is in fact PROJECT[-SUBPROJECT][-LOCALE].
8+
9+ubuntu daily-live * * ubuntu-cdimage/ubuntu
10+ubuntu-desktop-next daily-live -vivid * ubuntu-cdimage/ubuntu-desktop-next
11+ubuntu-desktop-next-system-image daily-preinstalled wily- * ubuntu-cdimage/ubuntu-desktop-next
12+kubuntu daily-live * * ubuntu-cdimage/kubuntu
13+kubuntu-plasma5 daily-live * * ubuntu-cdimage/kubuntu-plasma5
14+edubuntu dvd * * ubuntu-cdimage/edubuntu
15+xubuntu daily-live * * ubuntu-cdimage/xubuntu
16+ubuntu-server daily quantal- * ubuntu-cdimage/ubuntu-server
17+ubuntu-server daily-preinstalled xenial- * ubuntu-cdimage/cpc
18+ubuntu-server-live daily-live zesty- * ubuntu-cdimage/ubuntu-server-live
19+ubuntustudio dvd * * ubuntu-cdimage/ubuntustudio
20+mythbuntu daily-live * * ubuntu-cdimage/mythbuntu
21+lubuntu-next daily-live * * ubuntu-cdimage/lubuntu-next
22+lubuntu daily-live * * ubuntu-cdimage/lubuntu
23+livecd-base livecd-base * * ubuntu-cdimage/livecd-base
24+ubuntu-base daily * * ubuntu-cdimage/ubuntu-base
25+ubuntu-core daily-live * * ubuntu-cdimage/ubuntu-core
26+ubuntu-core-system-image daily-preinstalled * * ubuntu-cdimage/ubuntu-core-system-image
27+kubuntu-active daily-live * * ubuntu-cdimage/kubuntu-active
28+ubuntukylin daily-live * * ubuntu-cdimage/ubuntukylin
29+ubuntu-gnome daily-live * * ubuntu-cdimage/ubuntu-gnome
30+ubuntu-mate daily-live * * ubuntu-cdimage/ubuntu-mate
31+ubuntu-budgie daily-live * * ubuntu-cdimage/ubuntu-budgie
32+ubuntu-touch daily-preinstalled ubuntu-rtm/* * ubuntu-cdimage/ubuntu-touch
33+ubuntu-touch daily-preinstalled trusty- * ubuntu-cdimage/ubuntu-touch
34+ubuntu-touch-custom daily-preinstalled vivid- * ubuntu-cdimage/ubuntu-touch-custom
35+ubuntu-pd daily-preinstalled * * ubuntu-cdimage/ubuntu-pd
36+ubuntu dvd -precise * ubuntu-cdimage/ubuntu-dvd
37+ubuntu-wubi wubi * * ubuntu-cdimage/ubuntu-wubi
38+ubuntu-zh_CN daily-live -raring * ubuntu-cdimage/ubuntu-zh-cn
39
40=== modified file 'lib/cdimage/livefs.py'
41--- lib/cdimage/livefs.py 2017-04-29 04:14:46 +0000
42+++ lib/cdimage/livefs.py 2017-05-16 16:20:32 +0000
43@@ -301,6 +301,8 @@
44 image_type = config.image_type
45
46 path = os.path.join(config.root, "production", "livefs-launchpad")
47+ if not os.path.exists(path):
48+ path = os.path.join(config.root, "etc", "livefs-launchpad")
49 if os.path.exists(path):
50 with open(path) as f:
51 for line in f:

Subscribers

People subscribed via source and target branches