Merge lp:~vorlon/ubuntu-archive-tools/autopkgtest-retry-order-by-package-not-arch into lp:ubuntu-archive-tools

Proposed by Steve Langasek
Status: Merged
Merged at revision: 1112
Proposed branch: lp:~vorlon/ubuntu-archive-tools/autopkgtest-retry-order-by-package-not-arch
Merge into: lp:ubuntu-archive-tools
Diff against target: 25 lines (+4/-4)
1 file modified
retry-autopkgtest-regressions (+4/-4)
To merge this branch: bzr merge lp:~vorlon/ubuntu-archive-tools/autopkgtest-retry-order-by-package-not-arch
Reviewer Review Type Date Requested Status
Iain Lane Pending
Andy Whitcroft Pending
Review via email: mp+328409@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Andy Whitcroft (apw) wrote :

Reasoning for this change is sound when bulk loading from scratch into empty queues. The code change looks reasonable enough. One small documentation issue inline below.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'retry-autopkgtest-regressions'
2--- retry-autopkgtest-regressions 2017-04-21 21:01:24 +0000
3+++ retry-autopkgtest-regressions 2017-08-01 20:19:13 +0000
4@@ -88,7 +88,7 @@
5 for arch, state in archinfo.items():
6 if state[0] == retry_state:
7 regressions.setdefault(release, {}).setdefault(
8- arch, {}).setdefault(pkg, []).append(trigger)
9+ pkg, {}).setdefault(arch, []).append(trigger)
10
11 return regressions
12
13@@ -120,9 +120,9 @@
14 regressions = get_regressions(excuses_url, args.series, args.state,
15 args.min_age, args.max_age)
16
17-for release, archmap in regressions.items():
18- for arch, pkgmap in archmap.items():
19- for pkg, triggers in pkgmap.items():
20+for release, pkgmap in regressions.items():
21+ for pkg, archmap in pkgmap.items():
22+ for arch, triggers in archmap.items():
23 params = [('release', release), ('arch', arch), ('package', pkg)]
24 params += [('trigger', t) for t in triggers]
25 params += extra_params

Subscribers

People subscribed via source and target branches