Merge lp:~vorlon/lxc-android-config/apport-job-cleanup into lp:lxc-android-config
Status: | Needs review |
---|---|
Proposed branch: | lp:~vorlon/lxc-android-config/apport-job-cleanup |
Merge into: | lp:lxc-android-config |
Diff against target: |
161 lines (+23/-101) 5 files modified
debian/changelog (+8/-0) debian/lxc-android-config.maintscript (+2/-0) etc/init/apport-config.conf (+13/-10) etc/init/apport-reconfig.conf (+0/-33) etc/init/apport.override (+0/-58) |
To merge this branch: | bzr merge lp:~vorlon/lxc-android-config/apport-job-cleanup |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Ken VanDine | Needs Fixing | ||
Review via email: mp+285016@code.launchpad.net |
This proposal supersedes a proposal from 2015-10-15.
Commit message
Rework and simplify the apport overrides. Instead of adding two new upstart
jobs and an override for apport.conf, we can achieve everything we need to
with a single new apport job.
This leaves outstanding the issue that switching a device between channels
from the commandline will not cause the config to be correctly switched.
Description of the change
Rework and simplify the apport overrides. Instead of adding two new upstart
jobs and an override for apport.conf, we can achieve everything we need to
with a single new apport job.
This leaves outstanding the issue that switching a device between channels
from the commandline will not cause the config to be correctly switched.
Verified to work correctly on a stock Ubuntu 14.04 desktop system; will need
validating against the phone images also.
Unmerged revisions
- 14. By Steve Langasek
-
Merge from trunk
- 13. By Steve Langasek
-
Further refinement: no apport override needed at all, do everything in the apport-config helper job
- 12. By Steve Langasek
-
rm -f is always polite
- 11. By Steve Langasek
-
Further reduction of the apport override
- 10. By Steve Langasek
-
Simplify apport handling, to avoid duplication of the main apport.conf
where avoidable and to simplify the event start model (avoiding possible
deadlocks).
This no longer merges cleanly, please update the branch