Merge lp:~vorlon/launchpad/lp.994110 into lp:launchpad

[Steve Langasek]

Don't filter the blueprint list in the sprint export view based on the
spec's definition status. In Ubuntu, blueprints are sometimes (often)
carried over from one cycle to another and we want to rediscuss them at
subsequent UDSes. Since the feed is used as input to the session scheduler,
this extra check requires us to remember to toggle two separate things on
the blueprint to get it re-discussed. We should only need to target the
blueprint to the sprint to get it into the scheduler.

[Richard Harding (rharding)]

Steve, this change breaks tests in:

lib/lp/blueprints/doc/sprint-meeting-export.txt

The change itself is ok since we do disclaimer that it's not a stable interface to be used for tools other than the scheduler so once the tests are updated this should be all ok.

review: Needs Fixing (code)

[Chris Johnston (cjohnston)]

http://paste.ubuntu.com/976901/

[Curtis Hovey (sinzui)]

"We should only need to target the blueprint to the sprint to get it into the scheduler" is the insight needed to do the proper fix. Re-targeting is not updating the SpecificationDefinitionStatus for the drivers and workers to make it clear the definition needs to be realigned with the rest of the work for the series.

Unmerged revisions

15211. By Steve Langasek on 2012-05-08

Don't unnecessarily filter blueprints out of the feed for a sprint based on
their definition status

=== modified file 'lib/lp/blueprints/browser/sprint.py'
--- lib/lp/blueprints/browser/sprint.py	2012-01-01 02:58:52 +0000
+++ lib/lp/blueprints/browser/sprint.py	2012-05-08 15:01:20 +0000
@@ -470,11 +470,6 @@
             if spec.priority < SpecificationPriority.UNDEFINED:
                 continue
 
-            if (spec.definition_status not in
-                [SpecificationDefinitionStatus.NEW,
-                 SpecificationDefinitionStatus.DISCUSSION,
-                 SpecificationDefinitionStatus.DRAFT]):
-                continue
             model_specs.append(spec)
 
         people = defaultdict(dict)