Merge ~vorlon/germinate:feature-no-follow-build-depends-all into germinate:master

Proposed by Steve Langasek
Status: Merged
Merged at revision: 259c65ca918aeaacb976be60c190f68e3ddcf953
Proposed branch: ~vorlon/germinate:feature-no-follow-build-depends-all
Merge into: germinate:master
Diff against target: 37 lines (+12/-3)
1 file modified
germinate/germinator.py (+12/-3)
Reviewer Review Type Date Requested Status
Colin Watson Approve
Review via email: mp+376481@code.launchpad.net

Description of the change

This lets us drop an additional 106 packages (including nodejs) from the i386 set, and 7 from the set of packages needing to be autopkgtested.

To post a comment you must log in.
Revision history for this message
Steve Langasek (vorlon) wrote :

Fixed the merge conflict.

Revision history for this message
Steve Langasek (vorlon) wrote :

Noticed a problem with libprelude being left out of the seed despite being a build-dependency of audit (causing some binaries to be uninstallable, but more importantly making audit unbuildable). Fixed as in the latest commit.

Revision history for this message
Colin Watson (cjwatson) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/germinate/germinator.py b/germinate/germinator.py
2index 9b4e340..946e1a7 100644
3--- a/germinate/germinator.py
4+++ b/germinate/germinator.py
5@@ -1653,20 +1653,29 @@ class Germinator(object):
6 if pkg_src in output._blacklist:
7 seed._blacklisted.add(pkg_src)
8 else:
9+ # Special-case not following build dependencies of arch: all
10+ # packages
11+ if not self._follow_build_depends_all(seed.structure, seed) \
12+ and self._packages[pkg]["Architecture"] == "all":
13+ continue
14 seed._not_build_srcs.add(pkg_src)
15 seed._sourcepkgs.add(pkg_src)
16
17- output._all_srcs.add(pkg_src)
18- seed._build_srcs.add(pkg_src)
19-
20 # Special-case not following build dependencies of arch: all
21 # packages
22 if not self._follow_build_depends_all(seed.structure, seed) and \
23 self._packages[pkg]["Architecture"] == "all":
24 continue
25
26+ output._all_srcs.add(pkg_src)
27+ seed._build_srcs.add(pkg_src)
28+
29 if self._follow_build_depends(seed.structure, seed):
30 for build_depends in BUILD_DEPENDS:
31+ if not self._follow_build_depends_all(seed.structure,
32+ seed) and \
33+ build_depends == 'Build-Depends-Indep':
34+ continue
35 self._add_dependency_tree(
36 seed, pkg, self._sources[pkg_src][build_depends],
37 build_depend=True)

Subscribers

People subscribed via source and target branches

to all changes: